Pin Playwright E2E CI to Node 24#7596
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the Node.js version used by the Playwright E2E job in PR CI to a Playwright-supported Node release (24.1.0) while leaving the rest of the PR workflow on the default Node version (26.1.0), to avoid hangs during playwright install chromium.
Changes:
- Add
PLAYWRIGHT_NODE_VERSION: '24.1.0'to workflow env. - Switch the
e2e-testsjob’s dependency setup to usePLAYWRIGHT_NODE_VERSIONinstead ofDEFAULT_NODE_VERSION.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gonzaloriestra
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Pins the PR E2E job's dependency setup to Node 24.1.0 via
PLAYWRIGHT_NODE_VERSION, while leavingDEFAULT_NODE_VERSIONon Node 26.1.0 for the rest of PR CI.Why
The E2E jobs are hanging in
pnpm exec playwright install chromiumunder Node 26: the browser download reaches 100%, then the process emits no completion line until the 20-minute job timeout cancels it. Earlier Node 24 runs completed the same Playwright browser install in seconds.Playwright currently lists Node 20/22/24 as the supported Node.js versions, so the browser install should stay on Node 24 until Playwright supports Node 26.
Validation
git diff --checkpnpm exec prettier --parser yaml .github/workflows/tests-pr.yml >/dev/nullactionlintis not installed locally.prettier --checkalready fails on the base workflow formatting, so I used Prettier only as a YAML parser for this targeted workflow change.