Skip to content

Pin Playwright E2E CI to Node 24#7596

Merged
isaacroldan merged 1 commit into
mainfrom
fix/e2e-playwright-node-24
May 21, 2026
Merged

Pin Playwright E2E CI to Node 24#7596
isaacroldan merged 1 commit into
mainfrom
fix/e2e-playwright-node-24

Conversation

@isaacroldan
Copy link
Copy Markdown
Contributor

What changed

Pins the PR E2E job's dependency setup to Node 24.1.0 via PLAYWRIGHT_NODE_VERSION, while leaving DEFAULT_NODE_VERSION on Node 26.1.0 for the rest of PR CI.

Why

The E2E jobs are hanging in pnpm exec playwright install chromium under Node 26: the browser download reaches 100%, then the process emits no completion line until the 20-minute job timeout cancels it. Earlier Node 24 runs completed the same Playwright browser install in seconds.

Playwright currently lists Node 20/22/24 as the supported Node.js versions, so the browser install should stay on Node 24 until Playwright supports Node 26.

Validation

  • git diff --check
  • pnpm exec prettier --parser yaml .github/workflows/tests-pr.yml >/dev/null

actionlint is not installed locally. prettier --check already fails on the base workflow formatting, so I used Prettier only as a YAML parser for this targeted workflow change.

Copilot AI review requested due to automatic review settings May 21, 2026 09:11
@isaacroldan isaacroldan requested a review from a team as a code owner May 21, 2026 09:11
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Node.js version used by the Playwright E2E job in PR CI to a Playwright-supported Node release (24.1.0) while leaving the rest of the PR workflow on the default Node version (26.1.0), to avoid hangs during playwright install chromium.

Changes:

  • Add PLAYWRIGHT_NODE_VERSION: '24.1.0' to workflow env.
  • Switch the e2e-tests job’s dependency setup to use PLAYWRIGHT_NODE_VERSION instead of DEFAULT_NODE_VERSION.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@isaacroldan isaacroldan added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 0a8f0d3 May 21, 2026
32 of 33 checks passed
@isaacroldan isaacroldan deleted the fix/e2e-playwright-node-24 branch May 21, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants