Skip to content

[Refactor] Use uniq helper in import-extractor #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
May 22, 2026
+4 −3
Merged

[Refactor] Use uniq helper in import-extractor #7594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/cli-kit/src/public/node/import-extractor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {fileExistsSync, isDirectorySync} from './fs.js'
import {dirname, joinPath} from './path.js'
import {uniq} from '../common/array.js'
import {openSync, readSync, closeSync} from 'fs'

// Only read the first 128KB of each file for import scanning. This covers
Expand Down Expand Up @@ -125,7 +126,7 @@ export function extractImportPathsRecursively(filePath: string, visited: Set<str
}
}

return [...new Set(allImports)]
return uniq(allImports)
}

/**
Expand Down Expand Up @@ -183,7 +184,7 @@ function extractJSLikeImports(content: string, filePath: string): string[] {
}
}

return [...new Set(imports)]
return uniq(imports)
}

function extractRustImports(content: string, filePath: string): string[] {
Expand Down Expand Up @@ -215,7 +216,7 @@ function extractRustImports(content: string, filePath: string): string[] {
}
}

return [...new Set(imports)]
return uniq(imports)
}

function resolveJSImport(importPath: string, fromFile: string): string | null {
Expand Down
Loading