[Security] Harden archiver against Zip Slip traversal#7593
[Security] Harden archiver against Zip Slip traversal#7593gonzaloriestra wants to merge 1 commit into
Conversation
This change prevents files outside the input directory from being included in archives when using `zip` or `brotliCompress`. It validates that all files matched by glob patterns are subpaths of the intended input directory. - Filter paths using `isSubpath` in `zip` and `brotliCompress`. - Add a safety check in `archiveFile` helper. - Add regression test in `archiver.integration.test.ts`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
To prevent Zip Slip vulnerabilities where files outside the intended input directory could be included in archives via path traversal patterns in glob expressions.
WHAT is this pull request doing?
This PR hardens the
zipandbrotliCompressutilities in@shopify/cli-kitby:isSubpath.archiveFilehelper that throws anAbortErrorif a path escapes the trust boundary.archiver.integration.test.tsthat specifically verifies traversal attempts are blocked.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5148143385783206268 started by @gonzaloriestra