[Tests] Remove filesystem mocks in build.test.ts#7592
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
Refactor packages/app/src/cli/services/function/build.test.ts to remove global vi.mock('@shopify/cli-kit/node/fs'). All tests now use real filesystem operations within isolated temporary directories.
Key changes:
- Removed vi.mock('@shopify/cli-kit/node/fs').
- Wrapped tests in inTemporaryDirectory to provide a real filesystem context.
- Updated createWasmModule to generate valid WebAssembly binary buffers that satisfy WebAssembly.validate and WebAssembly.Module.
- Removed unused mocked imports and constants.
- Fixed ESLint line-comment-position errors in the modified file.
gonzaloriestra
force-pushed
the
jules-tests-remove-fs-mocks-build-test-1656486052323966662
branch
from
5f6a2ee to
0e42c77
Compare
1 participant
Description
Refactor
packages/app/src/cli/services/function/build.test.tsto remove globalvi.mock('@shopify/cli-kit/node/fs'). All tests now use real filesystem operations within isolated temporary directories.This improvement makes the tests more robust by exercising real path resolution and
WebAssemblyAPI interactions, which were previously bypassed by mocks.How to test your changes?
CI
PR created automatically by Jules for task 1656486052323966662 started by @gonzaloriestra