[Performance] Optimize linesToColumns#7588
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Cache unstyled lengths to avoid redundant calls to `unstyled()` - Use a single pass to calculate widths and lengths - Add early return for empty input
82f3c69 to
27b8703
Compare
- Cache unstyled lengths to avoid redundant calls to `unstyled()` - Use a single pass to calculate widths and lengths - Add early return for empty input
- Cache unstyled lengths to avoid redundant calls to `unstyled()` - Use a single pass to calculate widths and lengths - Add early return for empty input
WHY are these changes introduced?
The
linesToColumnsfunction currently performs two passes over the input data and calls the expensiveunstyledutility (which uses regex to strip ANSI codes) multiple times for the same strings. This introduces measurable overhead in CLI output generation.WHAT is this pull request doing?
linesToColumnsto use a single pass that caches the unstyled lengths of each cell.unstyledutility by 50%.How to test your changes?
CI
Post-release steps
None
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12050113292855011574 started by @gonzaloriestra