Skip to content

[Performance] Optimize linesToColumns#7588

Draft
gonzaloriestra wants to merge 3 commits into
mainfrom
jules-performance-optimize-lines-to-columns-12050113292855011574
Draft

[Performance] Optimize linesToColumns#7588
gonzaloriestra wants to merge 3 commits into
mainfrom
jules-performance-optimize-lines-to-columns-12050113292855011574

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The linesToColumns function currently performs two passes over the input data and calls the expensive unstyled utility (which uses regex to strip ANSI codes) multiple times for the same strings. This introduces measurable overhead in CLI output generation.

WHAT is this pull request doing?

  • Optimizes linesToColumns to use a single pass that caches the unstyled lengths of each cell.
  • Reduces calls to the expensive unstyled utility by 50%.
  • Eliminates redundant intermediate array mappings.
  • Adds an early return for empty or nullish input to improve robustness.

How to test your changes?

CI

Post-release steps

None

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12050113292855011574 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 20, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 20, 2026
- Cache unstyled lengths to avoid redundant calls to `unstyled()`
- Use a single pass to calculate widths and lengths
- Add early return for empty input
@gonzaloriestra gonzaloriestra force-pushed the jules-performance-optimize-lines-to-columns-12050113292855011574 branch from 82f3c69 to 27b8703 Compare May 20, 2026 13:48
- Cache unstyled lengths to avoid redundant calls to `unstyled()`
- Use a single pass to calculate widths and lengths
- Add early return for empty input
- Cache unstyled lengths to avoid redundant calls to `unstyled()`
- Use a single pass to calculate widths and lengths
- Add early return for empty input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant