Skip to content

[Tests] Remove filesystem mocks in function common.test.ts#7567

Open
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-function-common-test-2974459126850071803
Open

[Tests] Remove filesystem mocks in function common.test.ts#7567
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-tests-remove-fs-mocks-function-common-test-2974459126850071803

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

Goals 🎯

Replace fragile filesystem mocks with real temporary directories in packages/app/src/cli/services/function/common.test.ts.

Changes 🛠

  • Removed global vi.mock('@shopify/cli-kit/node/fs').
  • Updated getOrGenerateSchemaPath tests to use inTemporaryDirectory.
  • Updated generateSchemaService mock implementation to write a real schema.graphql file to the temporary directory.
  • Fixed a linting error caused by an unused import.

How to test your changes? 🧪

CI


PR created automatically by Jules for task 2974459126850071803 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 17, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 18, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 18, 2026 11:50
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 18, 2026 11:50
Comment thread .jules/tester.md Outdated
Comment thread packages/app/src/cli/services/function/common.test.ts
Comment thread packages/app/src/cli/services/function/common.test.ts
@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-function-common-test-2974459126850071803 branch 2 times, most recently from 127c67b to d8063ea Compare May 20, 2026 13:17
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 20, 2026 13:26
@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/ui/components/AutocompletePrompt.d.ts
@@ -20,13 +20,6 @@ export interface AutocompletePromptProps<T> {
     abortSignal?: AbortSignal;
     infoMessage?: InfoMessageProps['message'];
     groupOrder?: string[];
-    /**
-     * Throttle window in milliseconds applied to the search callback. Defaults to 400ms,
-     * which is appropriate for remote/paginated backends. In-memory consumers (where the
-     * search callback resolves synchronously) can pass 0 for instant filtering on every
-     * keystroke.
-     */
-    searchDebounceMs?: number;
 }
-declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, searchDebounceMs, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
+declare function AutocompletePrompt<T>({ message, choices, infoTable, onSubmit, search, hasMorePages: initialHasMorePages, abortSignal, infoMessage, groupOrder, }: React.PropsWithChildren<AutocompletePromptProps<T>>): ReactElement | null;
 export { AutocompletePrompt };
\ No newline at end of file

@gonzaloriestra gonzaloriestra force-pushed the jules-tests-remove-fs-mocks-function-common-test-2974459126850071803 branch from 5786cd9 to 9924abd Compare May 21, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants