Fix Apriel2 mask call for transformers 5.9.0#524
Merged
Conversation
`create_causal_mask` and `create_sliding_window_causal_mask` removed the `cache_position` kwarg in transformers 5.9.0 (deprecated and ignored since 5.6). Gate the kwarg on the existing `_TRANSFORMERS_V4` flag: pass it on v4 (where it's still required), drop it on v5+. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transformers 5.9.0removed thecache_positionkwarg fromcreate_causal_maskandcreate_sliding_window_causal_mask, causing all 60 Apriel2 modeling tests to fail on CI withTypeError: ... unexpected keyword argument 'cache_position'.# not used anymore but kept for BC). It is still required on transformers v4, where it remains functional._TRANSFORMERS_V4flag at the single call site inmodeling_apriel2.py: passed on v4, dropped on v5+.Test plan
Ran
fast_llm_external_models/tests/test_apriel2/against three transformers releases — all match the pre-breakage baseline.transformers==4.57.1: 2109 passed, 42 skippedtransformers==5.8.1: 2109 passed, 42 skippedtransformers==5.9.0(the CI-resolved version): 2109 passed, 42 skipped — previously 60 failed🤖 Generated with Claude Code