Skip to content

setnames() should treat different Encoding as non-equal strings#3849

Merged
mattdowle merged 3 commits into
masterfrom
fix3845
Sep 15, 2019
Merged

setnames() should treat different Encoding as non-equal strings#3849
mattdowle merged 3 commits into
masterfrom
fix3845

Conversation

@shrektan
Copy link
Copy Markdown
Member

@shrektan shrektan commented Sep 9, 2019

Closes #3845

@shrektan shrektan added this to the 1.12.4 milestone Sep 9, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2019

Codecov Report

Merging #3849 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3849   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          71       71           
  Lines       13443    13443           
=======================================
  Hits        13366    13366           
  Misses         77       77
Impacted Files Coverage Δ
R/data.table.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10dc94...3fd9894. Read the comment docs.

Comment thread inst/tests/tests.Rraw Outdated
@shrektan shrektan added the encoding issues related to Encoding label Sep 9, 2019
@shrektan shrektan mentioned this pull request Sep 13, 2019
25 tasks
@mattdowle mattdowle changed the title Closes #3845: setnames() should treat different Encoding as non-equal strings setnames() should treat different Encoding as non-equal strings Sep 14, 2019
Copy link
Copy Markdown
Member

@mattdowle mattdowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for catching this before release!

@mattdowle mattdowle merged commit 3883689 into master Sep 15, 2019
@mattdowle mattdowle deleted the fix3845 branch September 15, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

encoding issues related to Encoding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setnames() should not exit early if colnames encodings are different

2 participants