Skip to content

Post-merge cleanup for WMMA grouped conv fwd#3468

Merged
wj-laskowski merged 3 commits into
developfrom
streamhpc/cleanup-bilinear-profiler
Dec 22, 2025
Merged

Post-merge cleanup for WMMA grouped conv fwd#3468
wj-laskowski merged 3 commits into
developfrom
streamhpc/cleanup-bilinear-profiler

Conversation

@wj-laskowski
Copy link
Copy Markdown
Contributor

@wj-laskowski wj-laskowski commented Dec 19, 2025

Proposed changes

  • splitting WMMA grouped_conv3d_fwd_scaleadd_ab instances for faster build time
  • removing duplicate aliases from profile_grouped_conv_fwd_bilinear.cpp
  • removing the biggest shape from scaleadd_ab tests that resulted in 10min CPU time

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@wj-laskowski wj-laskowski force-pushed the streamhpc/cleanup-bilinear-profiler branch from a717a1e to 69ff9f5 Compare December 22, 2025 08:02
@wj-laskowski wj-laskowski changed the title Post-merge cleanup profile_grouped_conv_fwd_bilinear.cpp Post-merge cleanup for WMMA grouped conv fwd Dec 22, 2025
@wj-laskowski wj-laskowski marked this pull request as ready for review December 22, 2025 10:27
@wj-laskowski wj-laskowski requested a review from a team as a code owner December 22, 2025 10:27
@EnricoDeg
Copy link
Copy Markdown
Contributor

LGTM!

@wj-laskowski wj-laskowski merged commit a8aebb7 into develop Dec 22, 2025
25 checks passed
@wj-laskowski wj-laskowski deleted the streamhpc/cleanup-bilinear-profiler branch December 22, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants