Skip to content

TWP30 fixed#117

Merged
NicolasSandoval merged 4 commits into
PyAr:masterfrom
LeoCumpli21:37_TWP30_fix
Jul 4, 2021
Merged

TWP30 fixed#117
NicolasSandoval merged 4 commits into
PyAr:masterfrom
LeoCumpli21:37_TWP30_fix

Conversation

@LeoCumpli21
Copy link
Copy Markdown
Collaborator

@LeoCumpli21 LeoCumpli21 commented Jun 28, 2021

Summary

This PR closes LeoCumpli21#37. The brython module was used in order to properly display the output at the time it is supposed to.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

@github-actions
Copy link
Copy Markdown

Comment thread _sources/lectures/TWP30.rst
Comment thread _sources/lectures/TWP30.rst
@LeoCumpli21
Copy link
Copy Markdown
Collaborator Author

I'm closing this PR and reopening it when Brython's console is displayed on Runestone.

@y-martinez
Copy link
Copy Markdown
Collaborator

I'm closing this PR and reopening it when Brython's console is displayed on Runestone.

Maybe a better choice is to open it again and change the status to Draft and put [WIP] in the title like the #118 that I need the Brython module.

@AngelaRemolina
Copy link
Copy Markdown
Collaborator

AngelaRemolina commented Jul 3, 2021

@LeoCumpli21 I'm reopening this PR now that this AngelaRemolina/RunestoneComponents#13 is merged with master. Please try changing all the exercises of guessing the number with the python3_interpreter option to print inside the iframe. If the print still not works you could try to use the document module to append to iframe the "Alto" or "Bajo" message.

@AngelaRemolina AngelaRemolina reopened this Jul 3, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2021

@LeoCumpli21 LeoCumpli21 changed the title TWP30 fixed [WIP] TWP30 fixed Jul 3, 2021
@LeoCumpli21 LeoCumpli21 marked this pull request as draft July 3, 2021 04:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2021

@LeoCumpli21 LeoCumpli21 marked this pull request as ready for review July 4, 2021 00:27
@LeoCumpli21 LeoCumpli21 changed the title [WIP] TWP30 fixed TWP30 fixed Jul 4, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2021

Copy link
Copy Markdown
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!, there are some visual details. I think @angelasofiaremolinagutierrez will work on this later.

@NicolasSandoval NicolasSandoval merged commit 8718f7a into PyAr:master Jul 4, 2021
@LeoCumpli21 LeoCumpli21 deleted the 37_TWP30_fix branch July 5, 2021 15:37
reingart pushed a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TWP30 lecture

4 participants