UseCorrectCasing removes `<module>\` from `<module>\<cmdlet>` in vscode-powershell

[o-l-a-v]

Steps to reproduce

This does not happen if you have a file only containing:

Az.Monitor\Get-AzDataCollectionRuleAssociation

Thus:

1. VSCode settings.json contains: "powershell.codeFormatting.useCorrectCasing": true.

2. Create temp.ps1 with following content:

   Write-Information -MessageData 'Adding associations.'
   $DCRs | ForEach-Object -ThrottleLimit $DCRs.'Count' -Parallel {
       $null = Add-Member -InputObject $_ -MemberType 'NoteProperty' -Force -Name 'associations' -Value (
           [array](
               Az.Monitor\Get-AzDataCollectionRuleAssociation -SubscriptionId $_.'subscriptionId' `
                   -ResourceGroupName $_.'resourceGroup' -DataCollectionRuleName $_.'name'
           )
       )
   } 6>$null

3. Save. The content becomes:

   Write-Information -MessageData 'Adding associations.'
   $DCRs | ForEach-Object -ThrottleLimit $DCRs.'Count' -Parallel {
       $null = Add-Member -InputObject $_ -MemberType 'NoteProperty' -Force -Name 'associations' -Value (
           [array](
               Get-AzDataCollectionRuleAssociation -SubscriptionId $_.'subscriptionId' `
                   -ResourceGroupName $_.'resourceGroup' -DataCollectionRuleName $_.'name'
           )
       )
   } 6>$null

Expected behavior

Content should not change.

Actual behavior

Az.Monitor\ gets stripped.

Environment data

• PowerShell v7.4.5
• vscode-powershell v2024.2.2
• PSScriptAnalyzer in vscode-powershell v2024.2.2: v1.22.0
  • Changelog: https://github.com/PowerShell/vscode-powershell/releases

[o-l-a-v]

One more example:

# Add role assignments and eligibility schedules
$Subscriptions | ForEach-Object -ThrottleLimit 5 -Parallel {
    $null = Add-Member -InputObject $_ -Force -NotePropertyMembers @{
        'RoleAssignments'          = [array](Az.resources\Get-AzRoleAssignment -Scope $_.'id')
        'RoleEligibilitySchedules' = [array](Az.resources\Get-AzRoleEligibilitySchedule -Scope $_.'id')
    }
}

Becomes:

# Add role assignments and eligibility schedules
$Subscriptions | ForEach-Object -ThrottleLimit 5 -Parallel {
    $null = Add-Member -InputObject $_ -Force -NotePropertyMembers @{
        'RoleAssignments'          = [array](Az.resources\Get-AzRoleAssignment -Scope $_.'id')
        'RoleEligibilitySchedules' = [array](Get-AzRoleEligibilitySchedule -Scope $_.'id')
    }
}

So it removes the module-qualified name from the 2nd cmdlet only.

[liamjpeters]

I just did some digging into #2123 and discovered why this happens.

Essentially boils down to the command lookup that UseCorrectCasing uses as well as the module structure.

So

Get-Command 'Get-AzRoleEligibilitySchedule' | Select-Object Name,ModuleName,Version

Name                          ModuleName
----                          ----------
Get-AzRoleEligibilitySchedule Az.Resources

vs

Get-Command 'Az.resources\Get-AzRoleEligibilitySchedule' | Select-Object Name,ModuleName

Name                          ModuleName
----                          ----------
Get-AzRoleEligibilitySchedule Az.Authorization

Doesn't happen with Az.resources\Get-AzRoleAssignment as that does resolve to the module name Az.resources. Though the module name is actually Az.Resources (capital R), so it's not fixing that as you'd expect 😅

I will possibly explore some fixes