Skip to content

Fix Blade Blast default stage cap#9837

Merged
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
OursCodeur:issue-9836-blade-blast-stages
May 12, 2026
Merged

Fix Blade Blast default stage cap#9837
LocalIdentity merged 1 commit into
PathOfBuildingCommunity:devfrom
OursCodeur:issue-9836-blade-blast-stages

Conversation

@OursCodeur
Copy link
Copy Markdown
Contributor

Description of the problem being solved

Fixes #9836.

Blade Blast was modeled with Multiplier:BladeBlastMaxStages set to 900. I aligned the internal value to the tooltip's so #9728 works as intended.

Steps taken to verify a working solution

  • Verified a fresh Blade Blast skill now defaults to 50 stages in the sidebar and Calcs skill controls.
  • Added regression coverage setting Blade Blast to 51 stages to confirm damage doesn't increase past the 50-stage cap.

Blade Blast uses a stage count for blade hits per cast/per second. Its modeled maximum was set to 900, so defaulting staged skills to their maximum stages overinflated Blade Blast damage. Use the skill tooltip cap of 50 blades instead and cover the default plus over-cap input.

Fixes PathOfBuildingCommunity#9836
@jwfiredragon
Copy link
Copy Markdown

Why 50 stages? Lingering blades are capped to 40, so 50 is impossible unless the cap is per skill (which I don't think it is but am not sure of).

@OursCodeur
Copy link
Copy Markdown
Contributor Author

Why 50 stages? Lingering blades are capped to 40, so 50 is impossible unless the cap is per skill (which I don't think it is but am not sure of).

image

@Wires77
Copy link
Copy Markdown
Member

Wires77 commented May 6, 2026

There's an infamous mod that gives more blades: "Skills that leave Lingering Blades have +(5-10) to Maximum Lingering Blades"

Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into handling this correctly by using the mods from gear and bladefall to set the cap but it runs into the issue where it runs after CalcActiveSkill where stages calcs are done so it never properly works
Will use this until the time comes when we want to properly fix it

@LocalIdentity LocalIdentity merged commit a8a04bd into PathOfBuildingCommunity:dev May 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blade Blast defaults to 900 stages

4 participants