Fix crash when hovering over more damage calc breakdown for Kinetic Fusillade of Destruction#9752
Conversation
* Regenerates the skills because of a reference to KineticFusilladeOfDestruction instead of to KineticFusilladeAltX which is the proper key for the skill. This reference was causing errors for some of the hover tooltips in the calcs tab.
| -- This equals: X * (0 + 1 + 2 + ... + (n-1)) / n = X * n(n-1)/2 / n = X * (n-1)/2 | ||
| local avgMoreMult = moreDamagePerProj * (output.ProjectileCount - 1) / 2 | ||
| activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeofDetonation", ModFlag.Hit) | ||
| activeSkill.skillModList:NewMod("Damage", "MORE", avgMoreMult, "Skill:KineticFusilladeAltX", ModFlag.Hit) |
There was a problem hiding this comment.
This is the change that actually fixes the issue.
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
When you exported the gem from the game files, you were not using the latest update, which is why it removed lines. Please make sure in the future that you only commit lines that are relevant to your PR
I found the same crash on Charged Dash of Projection so fixed that too
LocalIdentity
changed the title
My apologies. I didn't realize that I had to set up another "source" for generating the file after updating the game through Steam. I tested that out this morning to conform my mistake. |
2 participants
Fixes #9735
Description of the problem being solved:
Regenerates the skills because of a reference to KineticFusilladeOfDestruction instead of to KineticFusilladeAltX which is the proper key for the skill. This reference was causing errors for some of the hover tooltips in the calcs tab.
I'm unsure if I should have allowed all of the generated changes, or just the one I'm targeting, but I figure because they are generated this would be expected. I am using the latest build of PoE as of the time of creating this PR.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
See issue.
After screenshot: