Skip to content

Fix Gem quality tooltips #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Apr 12, 2026
Merged

Fix Gem quality tooltips #9749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Classes/SkillsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ function SkillsTabClass:CreateGemSlot(index)
-- Do the stats one at a time because we're not guaranteed to get the descriptions in the same order we look at them here
local stats = { }
stats[qual[1]] = qual[2] * 20
local descriptions = self.build.data.describeStats(stats, grantedEffect.statDescriptionScope)
local descriptions = self.build.data.describeStats(stats, grantedEffect.statDescriptionScope, true)
-- line may be nil if the value results in no line due to not being enough quality
for _, line in ipairs(descriptions) do
if line then
Expand Down
52 changes: 50 additions & 2 deletions src/Data/StatDescriptions/active_skill_gem_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,20 @@ return {
[30]={
[1]={
[1]={
[1]={
k="milliseconds_to_seconds_2dp",
v=1
},
["gem_quality"]=true,
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="{0:+d} seconds to Base duration"
},
[2]={
[1]={
k="milliseconds_to_seconds_2dp",
v=1
Expand All @@ -771,7 +785,7 @@ return {
},
text="Base duration is {0} second"
},
[2]={
[3]={
[1]={
k="milliseconds_to_seconds_2dp",
v=1
Expand Down Expand Up @@ -1733,6 +1747,10 @@ return {
k="negate",
v=1
},
[2]={
k="canonical_line",
v=true
},
limit={
[1]={
[1]="#",
Expand Down Expand Up @@ -3283,15 +3301,35 @@ return {
[124]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]=1
}
},
text="Fires 1 Projectile"
text="Fires {0:+d} Projectile"
},
[2]={
["gem_quality"]=true,
limit={
[1]={
[1]=2,
[2]="#"
}
},
text="Fires {0:+d} Projectiles"
},
[3]={
limit={
[1]={
[1]=1,
[2]=1
}
},
text="Fires 1 Projectile"
},
[4]={
limit={
[1]={
[1]=2,
Expand Down Expand Up @@ -6066,6 +6104,16 @@ return {
[230]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="{0:+d} to Maximum Hiveborn"
},
[2]={
limit={
[1]={
[1]=1,
Expand Down
22 changes: 21 additions & 1 deletion src/Data/StatDescriptions/beam_skill_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,35 @@ return {
[2]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]=1
}
},
text="Beam Splits towards {0} additional target"
text="Beam Splits towards {0:+d} additional target"
},
[2]={
["gem_quality"]=true,
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Beam Splits towards {0:+d} additional targets"
},
[3]={
limit={
[1]={
[1]=1,
[2]=1
}
},
text="Beam Splits towards {0} additional target"
},
[4]={
limit={
[1]={
[1]="#",
Expand Down
122 changes: 119 additions & 3 deletions src/Data/StatDescriptions/gem_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4941,15 +4941,43 @@ return {
k="milliseconds_to_seconds",
v=1
},
["gem_quality"]=true,
limit={
[1]={
[1]=1000,
[2]=1000
}
},
text="Innervation lasts {0} second"
text="Innervation lasts {0:+d} second"
},
[2]={
[1]={
k="milliseconds_to_seconds",
v=1
},
["gem_quality"]=true,
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Innervation lasts {0:+d} seconds"
},
[3]={
[1]={
k="milliseconds_to_seconds",
v=1
},
limit={
[1]={
[1]=1000,
[2]=1000
}
},
text="Innervation lasts {0} second"
},
[4]={
[1]={
k="milliseconds_to_seconds",
v=1
Expand Down Expand Up @@ -7181,15 +7209,39 @@ return {
[263]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="Supported Skills have {0}% increased Cooldown Recovery Rate"
text="Supported Skills have {0:+d}% increased Cooldown Recovery Rate"
},
[2]={
[1]={
k="negate",
v=1
},
["gem_quality"]=true,
limit={
[1]={
[1]="#",
[2]=-1
}
},
text="Supported Skills have {0:+d}% reduced Cooldown Recovery Rate"
},
[3]={
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="Supported Skills have {0}% increased Cooldown Recovery Rate"
},
[4]={
[1]={
k="negate",
v=1
Expand Down Expand Up @@ -10110,6 +10162,10 @@ return {
k="negate",
v=1
},
[2]={
k="canonical_line",
v=true
},
limit={
[1]={
[1]="#",
Expand Down Expand Up @@ -10240,6 +10296,16 @@ return {
[374]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Killing Blows with Supported Skills cause Enemies to have {0:+d}% chance to Explode, dealing a tenth of their maximum Life as Damage of a Random Element"
},
[2]={
limit={
[1]={
[1]=1,
Expand All @@ -10248,7 +10314,7 @@ return {
},
text="Killing Blows with Supported Skills cause Enemies to have a {0}% chance to Explode, dealing a tenth of their maximum Life as Damage of a Random Element"
},
[2]={
[3]={
limit={
[1]={
[1]=100,
Expand Down Expand Up @@ -10785,6 +10851,20 @@ return {
[397]={
[1]={
[1]={
[1]={
k="reminderstring",
v="ReminderTextFlee"
},
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="Supported Skills have {0:+d}% chance to cause Monsters to Flee on Hit"
},
[2]={
[1]={
k="reminderstring",
v="ReminderTextFlee"
Expand Down Expand Up @@ -11500,6 +11580,16 @@ return {
[427]={
[1]={
[1]={
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="Kill Normal and Magic Rarity Enemies that have {0:+d}% Life or\nlower when Hit by Supported Skills"
},
[2]={
limit={
[1]={
[1]=1,
Expand Down Expand Up @@ -13846,6 +13936,10 @@ return {
k="reminderstring",
v="ReminderTextUpfrontCost"
},
[3]={
k="reminderstring",
v="ReminderTextTransfusionNearbyMinion"
},
limit={
[1]={
[1]="#",
Expand Down Expand Up @@ -20815,6 +20909,28 @@ return {
[776]={
[1]={
[1]={
[1]={
k="divide_by_ten_1dp_if_required",
v=1
},
[2]={
k="reminderstring",
v="ReminderTextPower"
},
[3]={
k="reminderstring",
v="ReminderTextSoulEaterNonAura"
},
["gem_quality"]=true,
limit={
[1]={
[1]=1,
[2]="#"
}
},
text="Consuming a Corpse with Supported Skills has {0:+d}% chance to grant a Soul per Power"
},
[2]={
[1]={
k="divide_by_ten_1dp_if_required",
v=1
Expand Down
4 changes: 4 additions & 0 deletions src/Data/StatDescriptions/minion_attack_skill_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2955,6 +2955,10 @@ return {
k="negate",
v=1
},
[2]={
k="canonical_line",
v=true
},
limit={
[1]={
[1]="#",
Expand Down
4 changes: 4 additions & 0 deletions src/Data/StatDescriptions/minion_skill_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6202,6 +6202,10 @@ return {
k="negate",
v=1
},
[2]={
k="canonical_line",
v=true
},
limit={
[1]={
[1]="#",
Expand Down
4 changes: 4 additions & 0 deletions src/Data/StatDescriptions/minion_spell_damage_skill_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1749,6 +1749,10 @@ return {
k="negate",
v=1
},
[2]={
k="canonical_line",
v=true
},
limit={
[1]={
[1]="#",
Expand Down
Loading
Loading