Fix Cluster Jewel imports not allocating correctly#7270
Merged
LocalIdentity merged 2 commits intoJan 21, 2024
Conversation
- Tidy up in BuildClusterJewelGraphs() to prevent allocSubgraphNodes and allocExtendedNodes from having duplicate nodes - Add in orbitOffsets into ClusterJewels.lua via export. Credit to Wires77 PathOfBuildingCommunity#4302 for figuring this out - Update the logic that calculates the orbitIndex in BuildSubgraph to use orbitOffsets
Member
|
This is great, so glad you figured it out. I spent a long time staring at this code trying to find the issue previously to no avail. |
LocalIdentity
approved these changes
Jan 21, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7210 .
Description of the problem being solved:
Cluster Jewel imports were not being imported correctly due to the downsizing of proxy groups. This PR updates the process by using
StartIndicesfromPassiveJewelSlots.luato set the orbit index offsets for respective orbit sizes.Positioning of the cluster jewel passives also now accurately in-game visuals as a result of this PR.
Steps taken to verify a working solution:
After screenshot: