Skip to content

Set the league combo to the league of the imported character, if possible#5573

Closed
pHiney wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
pHiney:add_league_information_to_save_xmls_for_imported_characters
Closed

Set the league combo to the league of the imported character, if possible#5573
pHiney wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
pHiney:add_league_information_to_save_xmls_for_imported_characters

Conversation

@pHiney
Copy link
Copy Markdown
Contributor

@pHiney pHiney commented Jan 9, 2023

Set the league combo to the last used if possible. Used for previously imported characters

Fixes : In some cases the correct league is not selected when going to re import a previously imported character.

Description of the problem being solved:

In some cases the correct league is not selected when going to re import a previously imported character. This is because the league information is not recorded in the XML and PoB cannot select the correct one.
I have tried to accommodate Ruthless and and have assumed they will fall back to their standard counter parts like league characters.

Steps taken to verify a working solution:

This will only appear to work if you have a private league, who's name is alphabetically before "Sanctum", or maybe Hardcore ??

  • Open a previously saved import build and see that the behaviour is normal.
  • Close the build, edit the XML by hand and add lastLeague="Sanctum" to the <Import ...> stanza. Open the build in PoB and see that Sanctum league is opened.
  • Close the build, edit the XML by hand and change lastLeague="Ssanctum". This league doesn't exist and Standard should be the new league. This simulates the league ending and an XML still having the original League name in it. Open the build in PoB and see that Standard league is opened.
    If you have Standard SSF and or SSF HC you can test other combinations
  • "Sanctum",
  • "Hardcore Sanctum",
  • "SSF Sanctum",
  • "HC SSF Sanctum",
  • "Ruthless Sanctum",
  • "HC Ruthless Sanctum",
  • "SSF R Sanctum",
  • "HC SSF R Sanctum",

Refs:

https://www.pathofexile.com/developer/docs/reference#leagues
https://api.pathofexile.com/league?realm=pc

Before:

image

After

image

Build I was using

https://pobb.in/yFB2Q71mlu8Q

@QuickStick123 QuickStick123 added the bug Something isn't working label Jan 10, 2023
@kiwixz
Copy link
Copy Markdown

kiwixz commented Aug 2, 2023

Works for me!

@pHiney pHiney closed this Aug 30, 2023
@pHiney pHiney deleted the add_league_information_to_save_xmls_for_imported_characters branch August 30, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants