Set the league combo to the league of the imported character, if possible#5573
Closed
pHiney wants to merge 1 commit into
Closed
Conversation
…y imported characters
|
Works for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the league combo to the last used if possible. Used for previously imported characters
Fixes : In some cases the correct league is not selected when going to re import a previously imported character.
Description of the problem being solved:
In some cases the correct league is not selected when going to re import a previously imported character. This is because the league information is not recorded in the XML and PoB cannot select the correct one.
I have tried to accommodate Ruthless and and have assumed they will fall back to their standard counter parts like league characters.
Steps taken to verify a working solution:
This will only appear to work if you have a private league, who's name is alphabetically before "Sanctum", or maybe Hardcore ??
If you have Standard SSF and or SSF HC you can test other combinations
Refs:
https://www.pathofexile.com/developer/docs/reference#leagues
https://api.pathofexile.com/league?realm=pc
Before:
After
Build I was using
https://pobb.in/yFB2Q71mlu8Q