Fix crash on loading build due to some minion skills#1880
Merged
LocalIdentity merged 2 commits intoMay 20, 2026
Merged
Conversation
LocalIdentity
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1677
activeSkill.minionListis unavailable during main-skill selector refreshipairs(nil)crash shapeRoot Cause
RefreshSkillSelectControlsentered the minion-control branch whenactiveEffect.grantedEffect.minionListexisted, but then iteratedactiveSkill.minionListdirectly. Some loaded/imported builds can have granted-effect minion metadata beforeactiveSkill.minionListis populated, so opening the build could crash onipairs(nil)and leave the user stuck in a startup crash loop.Fix
The selector now normalizes to
activeSkill.minionList or activeEffect.grantedEffect.minionListbefore iteration. CompareEntry had the same assumption and now uses the same fallback. Unknown minion ids are ignored while building display rows, preserving a usable UI for partially stale data.Validation
busted --lua=luajit ../spec/System/TestSkills_spec.lua11 successes / 0 failures / 0 errors / 0 pending : 63.531 secondsgit diff --checkRisk/Rollback
Risk is limited to minion selector population for skills with granted minion metadata. Normal active skills with populated
activeSkill.minionListkeep the same path. Rollback is this commit only.