Guard minion skill tooltip state#1879
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
This does not fix the core issue of why the tooltip is invalid. Somehow the mainSkill list is stale when changing anything else in the build fixes the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1787
minion.mainSkillRoot Cause
SkillsTab:AddSocketGroupTooltiptreatedactiveSkill.minionas proof thatactiveSkill.minion.mainSkill.effectList[1]existed. The issue stack shows that hover/tooltips can observe a partially populated minion state whereminionexists butmainSkillis nil, so the tooltip path could crash even though this is only presentation logic.Fix
The tooltip now validates the nested minion main-skill/effect state before rendering that optional subsection. Valid minion main-skill data is still rendered exactly as before; incomplete minion state is skipped rather than taking down the Skills tab.
Validation
busted --lua=luajit ../spec/System/TestSkills_spec.lua11 successes / 0 failures / 0 errors / 0 pending : 62.593 secondsgit diff --checkRisk/Rollback
Risk is limited to the optional minion main-skill tooltip section. Fully populated minion tooltips retain the same output; incomplete state no longer crashes. Rollback is this commit only.