Default From Nothing imports to small radius#1878
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
No longer an issue as the website now shows the radius value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1457
From Nothingjewel imports to the unique's knownSmallradius when the pasted text omits theRadius: SmallpropertyNodeInKeystoneRadiusso a missing or unavailable radius map returns false instead of indexing nilRoot Cause
Trade-site item text for
From Nothingcan omit theRadius: Smallline that is present in the in-game copy. The parser only setjewelRadiusIndexfrom an explicit radius property, so the imported jewel kept its From Nothing keystone data but had no radius. Passive tree code later used that missing radius while checking keystone-radius allocation support, which could crash on nil indexing.Fix
After parsing jewel mods,
From Nothingimports with no parsed radius now receive the generated unique's knownSmallradius. The keystone-radius helper also validates the radius before indexing tree radius maps, so malformed future jewel data fails closed rather than crashing.Validation
busted --lua=luajit ../spec/System/TestItemParse_spec.lua25 successes / 0 failures / 0 errors / 0 pending : 0.281 secondsgit diff --checkRisk/Rollback
Risk is limited to
From Nothingjewel imports missing radius metadata and to safer nil handling in one passive tree radius helper. Rollback is this commit only.