Skip to content

Fix persistent buff supports of the same category not stacking#1833

Merged
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Peechey:fix/stacking-persistent-buff-supports
May 18, 2026
Merged

Fix persistent buff supports of the same category not stacking#1833
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Peechey:fix/stacking-persistent-buff-supports

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 12, 2026

Fixes #1768

Description of the problem being solved:

Persistent buff supports like Direstrike I and II can stack so long as they are supporting separate skills. The issue was the Buff effectName was the same across these supports so we were overwriting. Updating to have the Buff effectName include the Tier.

Also fixed Direstrike supports not have the LowLife condition.

Added a test because I guess I do that now.

Supports affected:

  • Cannibalism
  • Clarity
  • Direstrike
  • Herbalism
  • Mysticism
  • Precision
  • Thornskin
  • Vitality

Steps taken to verify a working solution:

  • Verify buffs like Clarity I and Clarity II can be active at the same time given they are supporting different skills
  • Verify Clarity I and II on the same skill will only add Clarity II buff
  • Verify Clarity II on two different skills only adds one Clarity II buff

Link to a build that showcases this PR:

eNrlG9lu4zjyuf0VhIF56u34iuN04MzAcS4DScdrp7t3nwaMRNvapkSPSCXxDObft4rU6UOiksHuApuHbpusi1WsYrGKHv7y6nPyzELpieC82TlqNwkLHOF6wfK8-fXx-tNp85efG8MpVauHxUXkcZzp_tz4MNRfyLPHXu6Fy86bk_vpw-yxSRQNl0x9S0i2f-00icOplF-oD2AzGixZ2CRUOixwx9nEFxEwgFzRkDqKhXfsmfFRpIShrsIIZn3qBXPh_GDqJhTR-rzZaxKOgCB6E4T6MJxyumHhXFFFnimPALPT6XePTvu9z92T_uC4SSTMnTdHsGa6ZJfUh3-brbfgXkShVFUEjjqnCdp8zZh7EHJwlNKfhuxqsWCO8p7ZOPTUeEUD5zCP3lGvl6BagHfzsPcRV96ae2CRQ_DH_QThtpJ2p3fSPuqdDE56vV5_kEr1KBTll9P5Qbx2EVKouhy-e2p1wUG_ZVxKcCfLwFPsjchT4UkR1FqfFfA44hy8zQp2xiQLn6nyygU5sIqx8J-8oFx7Kat7GtCxkMoOcspCcHRVC2HOHAGxoS6Pmph33oLZQ9ZaR4xQV5q3reNqbgtXm_DbBJpBRLSDnIuIl0IOUkh1OEJ1TnqZG_xWCpnGskv2Ws10EpQEov4gx7QMsp3xfBbooBZhIvSeIlUSZz8fDbrHnd7gc6_T7h0XosvV7fRw7O-mQk9XG-k5lN_TV8-PfIjtj_QHCyxUd-ctVyqAwFQf9doLWX2sseCuLVY3i2krKqQ1WruTBRQvuKWBO3KcCFKRjYVdafgjYFLaRmmIs1UYJ_18XDgI1s_lFs4Zgk4Cx5Lo1yCMpSnZLkeDAs4MogAmP0-8ZG-22_vZxMHELhTO2JIFMbuNHcodY87qBqw3oyWu0y-cHBYhCjWLoGWaLRK10GxOSUWMKiX1jk7yiDXVhCh2asoJOF97kCkehPzU2YK0WH4JjvUuuQpYuNzMVx7jbj3oRF9jura0fx67bB8cYFfLRnlUO1sVDl47bukxcPVMpdWRZPRgoO1U8ExdVnFfyDYmg-S9FsY0FP_CKxKvhwbL4Lw-xhu5XbIFRzSBBoQT0xqj6p7Vxr_0Phr6IgotTWiAyyz4ub2dI5hL7oy5kWOXv6TX1wsOt3VbbaVYWuW1UEdKUefHpXCX9exaC6Mo3zxaryFooT9UEPiUHQ-YAEES4NkkxxnsA_hyWbDKMcBcyZZBBluDQZr92XLZQqhi1S7kb9ZLyYCrGHR2zHkPsdKHM0cXaO7F4dMkX6GRDEw-o64XyXum4LuFQeE-b3XD1oCWRYKpeIH1rrDodliE3j5oyI0tRAlZ8PvGmn4B3IrBVeBCmg26tOaxjZGxuYgWC0kc4T9RdQdb4bzZJE8wZj6POYVMY0MmfyPpR_h8CW4mVej9YGTSJJDzSxbjGqKPng-Hk5SXVFHixle4b4BPA9Ux20lXJK89rlh4Cagom1kho6GzQmrXlPMniFAoUTaK37YodpEiMh62dIEVP00U8yWRK_GC-rj0YN-GuPtkUhalehsj2JwpLVIkmbmxf2d0LQI9vKBcMlMlRVDiuUnV9MNMq-OMzEazq0YS9Un3ltxThzWuIWtUnkNuQkbVivo-CxvjkC4Uc88IStAAf1h4r2fkjxCru2fto_6fdwJIwDEDOBKyusJJEud4_TfijbLLmTlWDxMaue42kccXgde7k8YcdkYpc3Oo6KjQOwiNVVQkPtdbyJwEe6FvuHiC6zYmOvMfHuc3zNc17lgeY6jjxt8jyrUtuu2Gnp-x387I4LQx8dfcczwlz0in8YeiS3lGtYB_GtYSthIYbb7mVK6IWWujM-j-RLxkQSQ1bTwN6pGke0yUIMedndmPnU4HpxJlE6Ptxsfu0fFPOJGsncD9mpilNzoFhkaFROuw8fEEkfSiiFgQcAmi1UG0PiRuxCGEX90hIFpx4EVHcAHFndo17lgC0auEOK6E6FdCnFRCDOLA0UIvS90NXLDEK_POOJxzoYgHONOnr7M7DBKB7pBA6ka6TT0zcTHAtMrhMT76pFcDw8hFumT-AidoXU6d2hh1VnPHlrU4jGpKFK-9U3ftKFeddVyDf_6ohTEDp6uPUGftF0IoWQeecVWLvLsh8S3FHuuWcZ-pN1gwQ-lUbhI_4m_hUccaEPifmay9Qzp1Db7r6CYEQZgxiUwIN9e5Tj6-M0zKpckzdHqBn8aUO9IErGAdKYJZEbaBr66vr8aPk29XCTvfk86vmFhhbzZmZVCCyH9ioU5BDKjE0P6rGY4h5-ZGDHka53QNp0QhCOqzYM7wEgypUvQkDfR585vHXvTkJVPU49KKGhxMcYe2QEvTyeZsKH0HvYUe2jFP6OqVhXgmprM2pLC_uSuOkQXLNphx2ulKd5QLpMyBO6ZS5UpG5VTwFC8SwRG7pUBSQvmWcuMxa2M_btYME1u5RykK5uSaOd7CcwyMpdXjK3lRN8WKfjkN3U0u4pshG2TTES5ix2NWWtXd6C2tmjGr_cUcuilimyEb5LTkWCSQDovgNi0Gl1O64mzkcbxYb1n2iwj0Zge_SQFsCN5D2DGX9i2CD2rFwmTGhhJ4iemwyR3vScatdIW9maKasm5NxVqw-VBAzbUjqrze2_HYQo2-wiz5unkxmO1W1MtJxdWZAhEzZmmGOCUomCBfzKxYSVy7Li6iUNCucBQdckfPwnN3o8X25LsJ6oLmXyAXliz_AjJpadqKls5JtrwlHjuIbooTh7C_Kg8vuu8jgv72Pgrodu-joK8yVtiznURkVpp-ZJhJcWyH8ZLJN-OnhbQ3UzDlvjej62qkdeiHHaurXntifzr1PlpzFQWXoJJyr8gWVSGVReywp2UOyloLjetd-uHDntCWfxHxHkJwjN_a5osHKaXF-FtGOT6pE_x9BPe__Cg1wUFa2E6N1jRwE2oPdbL0w9qDSzcQ1XXeS2zbyndJCce3v8nRGbaSC93wi4CUBknjaPJlOBbBwlvG1WPzJa4faynSEaI8xZk-MmikL_65YlXxqvjRdCYJjU92cwl0IqmED5dFmVxkDdYTWJnRIFldDCwC18MV3YmXLJ2yQ7kOxe8s0IoAm4G_8E0Rfed-mqKORRhGa7zLjcMNXDXSwKp7EQ5bCe6ycM8F11t6_GGhQ1k12md8g2MQGUqZNsfyN9H9qNiCy2FuN_qskPY27_ZjdouYSV-jDGVLwO3-3X6k025RQqwO19Egdkmrldfb0d00iQkH7Nt-7w4ZtIv6yD3_PsAyXZifvsrG58UsZO5c3-pFFKg544vSlZ6e7JqhWkHZel3mgyOJ0Nc8S5d42j4pKjafvNsYAo1XYYiitbfft9swSTd9lcl31Y8JQcDc7Vhi4S9Ja-Q7o_qlX7UyU_bzFdwTquEHWw5q3mjAiaG7EnVcCN3BYofsqidpRaqR7wu0pVuHbbEtV8q6MyiiFi55Vep0ROisqvW5FSq3X2pYK0WXAjdfpd226WQNEax72u-SPVa4gX-oyyoN0dvdqoVCaCs9-U0Wob_hx8eQMSzDkt-F8P-hAz5--meu2T1XIZalcfjO_DAH-_YHW9c6T5n4axEqwl7xvykN1SbJn1oJ1zhJwRdMaX6CX_I_IzKFb6JQyOzXR_hmQ_fcaLgZFYEDj4MihIvS9NvH_c_4AyOpWLiJa0m4EsMAIs5mEsBUQDmixj9pyg91kzEthtH-19md_vBhpdRanrVaLy8vR2uqVmLBXj3Ojhzht9aABGv7pEvln1D81gj-LpYj_acJtRJKQ_PzJxmbFxPR0HNNcgff0wJWMkFc9vrFLBHfT4TpZy9QyeeYVqtAbNhC_eoNgAbAD9o0BMLTy8h9xhj8CMmYTHNdQITDkcZlHA66pes16K5gTNPqJRIsfcN8ebG5nM6vseBU_BGK2TLRem3gsEQMjEZ3d80iapIHuiY1TXrqYFs4wNLH7ckLibi3YJ5IZChxyz0x2zABKzZlcRA72zxy2SSI3_Kki-f0Cdnir-fwdbSb_8XaKGOuM3LNfmsiZfRhCBLply4gwSQA88UbdWlaO_dMUZcqato2LdREK1NU_LAFtIREET6eiyfMsxrj_saZ0qcwTfJbpod4GebNQjdZTH6wkwymv78rCB0vVEvuYN6iIbaU82zevKCYsRixtPGWfJMu4rcVoxCU66QVxkQd-eFdZZjZtFX5LoV02-_TSGEBrb9ubzy-iIrtoSH27JD_7BaJHevgHkEp82o5qIOcCvCtl3kts6uC7B3Y7r4ovhF7rxJsrJ9xLLrE0Gzw__WYlLohVkkeFl9MLy3ReDa4q2qcw9dBBuW_6oE52f8P_a8iRGfuZ7UlNZd6G1KjlG_J6v1nNBpXrrq3-J4xp339_MyM7u5EHCVJtHj3RrTR8D5hd3Qcf0yyc5NQ_dwYtnZ-o_9vXHzVQQ==

Before screenshot:

image

After screenshot:

image

@Peechey Peechey added the bug: behaviour Behavioral differences label May 17, 2026
@LocalIdentity LocalIdentity merged commit 33aec4f into PathOfBuildingCommunity:dev May 18, 2026
3 checks passed
@Peechey Peechey deleted the fix/stacking-persistent-buff-supports branch May 18, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple persistent buff supports in the same category disregarded in calculations

2 participants