Test and support new option for *express-minify* with keeping comments

[Martii]

See also:

• Keep comments? breezewish/express-minify#15
• 1b595bb
• Uglified code breaks Greasemonkey scripts mishoo/UglifyJS#583 (fixed with Keep single line comments after nlb, after nlb mishoo/UglifyJS#608 ... retested with known derivations to the UserScript metadata block including tab characters... not released yet though v2.6.1+)
• Harmony support mishoo/UglifyJS#448 (git://github.com/mishoo/UglifyJS2#harmony and git://github.com/OpenUserJs/UglifyJS2#harmony-named+cdba43c) (WIP)
• Beautify mode: comments are lost in the end of function body mishoo/UglifyJS#88 (not blocking yet) ... may be fixed
• NFR: Experimental branch for *UglifyJS2*  breezewish/express-minify#42
• NFR: catch callbacks, emitters, or equivalent options breezewish/express-minify#44
• Establish the core UI elements with bootstrap
• Establish testing methodology (loading two instances of UglifyJS2 and separated out handling of package .js vs userscript/lib scripts)
• Establish permanent url usage
• Custom config UglifyJS2 options. (partially started)
• [ES1-7] return outside of function mishoo/UglifyJS#935 with PR Create and map bare-returns into new parse property name mishoo/UglifyJS#962
• [ES6] Error when parenthesis string is envolved by parenthesis mishoo/UglifyJS#1001
• OpenUserJS metadata block option to denote possible unstable with minification but still allow... Change UI coloring and notice of "The script author suggests that minification of this script may be unstable."
• Migrate to terser
• Submit Code *[as Fork]* generates Payload Too Large #793

---

SummerWish f.k.a Breeswish was gracious enough to grant the request for enhancement and a personal thank you goes out.
avdg fixed the newline issue in the UserScript metadata block with minification.... once again thank you too.

---

OUJS refs:

• https://openuserjs.org/discuss/How_to_disable_install_with_minification_on_my_script

[Martii]

Before I get too gung ho on this... should there be an opt out in user preferences when logged in? or should we always minify on production (for user.js installs and what about the ../src routes?)?

[Zren]

Never minify the user.js. None of the other sites minify by default.

End users should not have to deal with minification.

[Martii]

Well we should be the first to offer a feature that beats out the other run of the mill sites. ;) And that's not entirely true... gf, in a similar fashion, has discussed default languages via whatever persistent storage... which this can be considered inclusive.

And yes end users should be dealing with portable device constraints. JavaScript white space can take around 20% to 30% of mass storage which is really just wasted space (this was proven with CI btw on USO).

The only reason I offer a question here is because if someone wants to back up their unminified code (say they aren't on GH for some reason) they can... but the ../src route could not minify.

See also:

• Terms of Service/Privacy Policy/DMCA #116 especially sizzles responses.

[Zren]

first to offer a feature

Minification is not a feature for end users. It's a feature to lower bandwidth for the server owner. One of our rules is to not minify your scripts, why in tarnation would we then minify it for the user so he can't read/edit the source in his GM addon?

We could use gzip compression to transfer it to the user if bandwidth is the issue.

[Martii]

One of our rules is to not minify your scripts

No it's not... see https://openuserjs.org/about/Terms-of-Service#minification

We could use gzip compression to transfer it to the user if bandwidth is the issue.

We already do... see https://github.com/OpenUserJs/OpenUserJS.org/blob/f3233decd7368aeb1fa425ffbd4a24abc8395fb0/app.js#L7 and https://github.com/OpenUserJs/OpenUserJS.org/blob/f3233decd7368aeb1fa425ffbd4a24abc8395fb0/app.js#L68

why in tarnation would we then minify it for the user so he can't read/edit the source in his GM addon?

...

should there be an opt out in user preferences when logged in?

Can offer an opt in too... I am just handing the conch around with this question.

Btw haven't seen "tarnation" in a looooooong time. ;)

[Zren]

should there be an opt out in user preferences when logged in?

No because you assume the person will always have a logged in session, which they won't. You assume the GM addon will even send the cookies to signal there's a session, which I'm not sure about.

Er wait... who has the opt in option? An end user (see issues above) or a script auther (see issues in previous comment).

[Martii]

who has the opt in option?

I don't always follow to conclusion every greasyfork (gf) issue but it was under discussion last time I read for default languages (i18n or whatever silly name someone wants to use).

No because you assume the person will always have a logged in session, which they won't. You assume the GM addon will even send the cookies to signal there's a session, which I'm not sure about.

And because I maintain the GM Port on SF I know exactly what GM will do and not do currently... updating on a portable device will most likely not be logged in to conserve their bandwidth $$$ not ours... so logged out would either need something persistent in the user.js engine/browser or just default to on... which leaves logged in for opt out. I've had many months (technically years before the divestiture of USO) to think about this even before gf thought about it for translations ... but I wanted to hear some feedback before I go "gung ho" on this.

[Martii]

I do want you to cross-examine a similarity between your quotes here and notice something:

why in tarnation would we then minify it for the user so he can't read/edit the source in his GM addon?

...

Except chrome (and probably firefox) can unminify/prettyprint it for you.

[Zren]

updating on a portable device will most likely not be logged in to conserve their bandwidth $$$ not ours...

You could check UserAgents but that would be a bitch to keep track of. It would also make testing a pain in the ass. Also, they are not downloading unless there's an update. The GM addon should prompt before downloading over their data plan. We're also talking about files < 1 Mb here... If that's costing you 1% of your data plan, then get on wireless beforehand ffs.

I do want you to cross-examine a similarity between your quotes here and notice something:

One comment is about something the end user see (userscripts). The other is about shit the developer sees (who has tools to unminify). Also, most GM addons editors are a POS (textareas). Users should not have to unminify to read/edit a userscript.

[Martii]

An end user (see issues above) or a script auther (see issues in previous comment).

And yes that is another valid question... which I missed the first read around above... I thought of that too... serving minified by author choice could be an option too.