Add related-sampling-features object methods

[SRGDamia1]

ie., give a sampling feature object a method like "get related sampling features."

[emiliom]

Has this been implemented already? If not, @lsetiawan, does it seem like something we (ok, you!) could implement fairly easily? @horsburgh, any thoughts?

[lsetiawan]

Not sure, I'll have to look at the code in detail first.

[horsburgh]

@emiliom - I don't believe this specific function has been implemented yet. I think @Elijahwalkerwest and @Maurier may have iterated on another endpoint that may have something similar in it. @Elijahwalkerwest - did you do something similar in the getSamplingFeatureDatasets function?

[Elijahwalkerwest]

Similar feature yes but the implementation is different. How do we want this inplemented exactly? Do we want the samoling feature end point to just return related features as well?

[horsburgh]

@Elijahwalkerwest - just wondering if there was code we already developed that we could reuse. Good question about the getSamplingFeatures function. @emiliom - do you have a a preference for a separate function? It might be easier to implement and wouldn't break anything that currently uses getSamplingFeatures.

[Elijahwalkerwest]

No, cant reuse the code exactly but near enough that it wouldnt be hard to implement. As far as im aware theres already a pythonapi get related features. So either restful endpoiny or roll it in to getsamplingfeatures. Shouldnt be hard either way.

[horsburgh]

Ah - well, @Elijahwalkerwest, this issue is in the ODM2 PythonAPI repo, so if there is already a getRelatedSamplingFeatures can you provide a link to the code here and then we can close this issue right?

[Elijahwalkerwest]

Oof. Commenting on mobile and forgot to look. Yeah im using it in the getsamplingfeaturedatasets actually. Let me double check when i get in to work tomorrow and link the relevant code and close.

[emiliom]

@emiliom - do you have a a preference for a separate function? It might be easier to implement and wouldn't break anything that currently uses getSamplingFeatures.

I would agree.

[lsetiawan]

Here's getRelatedSamplingFeatures in the readServices. Thanks @Elijahwalkerwest and @horsburgh, I should've known this existed. 😞 sigh Still have traces of holiday brain i guess haha.

[emiliom]

Thanks for finding this, @lsetiawan.
Closing the issue

[emiliom]

It looks like getRelatedSamplingFeatures had actually been around since April 2016. See 599b6cd.