[18.0][FIX] queue_job: remove create/delete permissions#927
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from May 1, 2026
Merged
[18.0][FIX] queue_job: remove create/delete permissions#927OCA-git-bot merged 1 commit intoOCA:18.0from
OCA-git-bot merged 1 commit intoOCA:18.0from
Conversation
Jobs are always created through sudo() in the Job class, and always deleted by the cron, never by users. See discussion on OCA#802 (comment)
Contributor
|
Hi @sbidoul, |
sbidoul
approved these changes
Apr 30, 2026
guewen
changed the title
This was referenced Apr 30, 2026
amh-mw
approved these changes
Apr 30, 2026
Member
amh-mw
left a comment
amh-mw
left a comment
There was a problem hiding this comment.
Functionally tested locally. LGTM.
Member
Author
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 879d1a7. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jobs are always created through sudo() in the Job class, and always deleted by the cron, never by users.
See discussion on #802 (comment)