[14.0][BKP] queue_job: unify no delay option#680
Merged
OCA-git-bot merged 1 commit intoOCA:14.0from Sep 4, 2024
Merged
Conversation
Current situation: * multiple keys for no good reason * half baked: not all of them used everywhere * no centralization * poor naming With this change we'll have: * 1 and only one key to disable via ctx: ``queue_job__no_delay`` * 1 and only one key to disable via os env: ``QUEUE_JOB__NO_DELAY`` * backward compatibility with deprecation for old keys
Contributor
|
Hi @guewen, |
1 task
simahawk
commented
Sep 3, 2024
| deprecated_keys = ("_job_force_sync", "test_queue_job_no_delay") | ||
| for key in deprecated_keys: | ||
| if env.context.get(key): | ||
| _logger.warning( |
Contributor
Author
There was a problem hiding this comment.
NOTE: the warning here is the same we had already + the deprecation message.
Contributor
Author
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at ee55b99. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation:
With this change we'll have:
queue_job__no_delayQUEUE_JOB__NO_DELAYBackport of #521