fix(core): depend on released cuda-pathfinder >=1.4.1#1735
Merged
cpcloud merged 4 commits intoNVIDIA:mainfrom Mar 7, 2026
Merged
fix(core): depend on released cuda-pathfinder >=1.4.1#1735cpcloud merged 4 commits intoNVIDIA:mainfrom
cpcloud merged 4 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Add a shared `optional_cuda_import` API in cuda.pathfinder so optional module checks only suppress genuinely unavailable modules or dynamic libs while still surfacing nested import bugs. Wire cuda.core NVVM/nvJitLink detection to this helper and declare cuda-pathfinder as a direct cuda-core dependency. Made-with: Cursor
Apply ruff-preferred import ordering in pathfinder exports and rename an unused test lambda argument so repository-wide pre-commit checks pass cleanly. Made-with: Cursor
Raise the cuda-core dependency floor to cuda-pathfinder>=1.4.2, move the new optional import note to 1.4.2 release notes, and simplify nvJitLink warning text by inlining the fixed version detail. Made-with: Cursor
Set the cuda-core runtime dependency to cuda-pathfinder>=1.4.1 and add a TODO to bump to >=1.4.2 after that release is available so environment solves continue to work. Made-with: Cursor
cpcloud
force-pushed
the
pathfinder-issue-980-new-pr
branch
from
f159931 to
0242b72
Compare
cpcloud
changed the title
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
rwgk
approved these changes
Mar 7, 2026
|
cpcloud
added a commit
to cpcloud/cuda-python
that referenced
this pull request
Apr 28, 2026
Roborev review NVIDIA#1735 flagged two issues with the unlink-retry commit: 1. **HIGH**: schema-mismatch wipe in __init__ suppressed every PermissionError then advanced the schema marker anyway. If a Windows-locked entry survived the wipe, future opens would skip the wipe and lookups could return bytes from the incompatible old format. 2. **MEDIUM**: _enforce_size_cap and _prune_if_stat_unchanged suppressed every PermissionError, hiding real configuration failures (POSIX ACL issues, Windows non-sharing winerrors). Fix: add ``_is_windows_sharing_violation(exc)`` so best-effort callers can filter the exhausted-Windows-sharing case while letting other PermissionError instances propagate. Apply at: * ``_prune_if_stat_unchanged``: catch + filter; non-sharing PE re-raises. * Schema-mismatch wipe: track ``wipe_complete``; only advance the schema marker if every old entry was successfully removed. * ``_enforce_size_cap``: catch + filter. Tests cover the new propagation paths (POSIX PermissionError surfaces, not silently swallowed) and the schema-marker preservation when an old entry is locked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
Supersedes #1733.
Summary
cuda-coreto depend on releasedcuda-pathfinder >=1.4.1instead of unreleased>=1.4.2cuda_core/pyproject.tomlto bump to>=1.4.2once that release is availableTest plan
nix run 'nixpkgs#pre-commit' -- run check-toml --files cuda_core/pyproject.toml