Skip to content

Add support for shapely 2.0 and many tests#486

Merged
xylar merged 11 commits into
MPAS-Dev:masterfrom
xylar:support_shapely_2.0
Jan 4, 2023
Merged

Add support for shapely 2.0 and many tests#486
xylar merged 11 commits into
MPAS-Dev:masterfrom
xylar:support_shapely_2.0

Conversation

@xylar
Copy link
Copy Markdown
Collaborator

@xylar xylar commented Dec 29, 2022

This merge includes a lot of clean up and testing related to ensuring that we can support shapely >=2.0,<3.0. Most of the changes are in masking, with a few related to transect visualization.

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Dec 29, 2022

This is in draft mode because it needs MPAS-Dev/geometric_features#189

@xylar
Copy link
Copy Markdown
Collaborator Author

xylar commented Jan 4, 2023

Testing

I have tested a branch of compass (MPAS-Dev/compass#490) that uses these changes and results of the pr test suite was bit-for-bit. So I am confident in the masking changes here.

The new tests also mean that there should be no broken or deprecated features related to shapely.

@xylar xylar marked this pull request as ready for review January 4, 2023 12:26
@xylar xylar merged commit 7d3a87e into MPAS-Dev:master Jan 4, 2023
@xylar xylar deleted the support_shapely_2.0 branch January 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant