Skip to content

Fix a bug in linking a python script for the vegetation idealized_tra…#791

Closed
caozd999 wants to merge 1 commit into
MPAS-Dev:ocean/developfrom
caozd999:fix_a_bug_in_vegetation_case
Closed

Fix a bug in linking a python script for the vegetation idealized_tra…#791
caozd999 wants to merge 1 commit into
MPAS-Dev:ocean/developfrom
caozd999:fix_a_bug_in_vegetation_case

Conversation

@caozd999
Copy link
Copy Markdown

This bug appeared in linking the python script comparison.py to the script_test_dir directory. It intended to provide the path of the python script by using path_base, which generated to a invalid hyperlink of the script and failed to run the analysis. Changing it to source_path fixed this issue.

@caozd999
Copy link
Copy Markdown
Author

caozd999 commented Jan 14, 2021

This obvious bug was not detected in #651, because it was the last modification after the PR was submitted. @sbrus89 provided the right command, but I modified the script wrong and didn't rerun the case to find it out.

@xylar xylar added the Ocean label Jan 14, 2021
@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Jan 14, 2021

@caozd999, we are no longer making any changes to COMPASS on this repo. Please make this PR to https://github.com/MPAS-Dev/compass. If you need help with migrating to that repo, please take a look at this documentation: https://mpas-dev.github.io/compass/stable/ and then get in touch (e.g. on Slack).

@xylar xylar added the COMPASS label Jan 14, 2021
@caozd999
Copy link
Copy Markdown
Author

@xylar Thanks. I created a new PR on MPAS-Dev/compass repo.

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Jan 15, 2021

Great, we can just close this one, then, and you can delete this branch.

@xylar xylar closed this Jan 15, 2021
@caozd999 caozd999 deleted the fix_a_bug_in_vegetation_case branch January 15, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants