This PR fix the error in PR#1438 #1440
Closed
smileMchen wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@mgduda |
Contributor
@smileMchen I've added the fix from this PR to set snow to zero only over water points to PR #1438. Could you check that the changes in 2075068 (currently a separate commit in PR #1438) are as you intended them? If everything looks good for PR #1438, I'll suggest we close this PR and continue with #1438. |
Contributor
Author
Contributor
|
Great -- we'll proceed with PR #1438! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in PR#1438 that all snow information, snow water equivalent(swe), snow depth(snowh), and snow cover(snowc), over land areas are removed mistakenly.
In the initialization of snow over seaice areas, we use xice as a criteria to determine whether snow should exit or not. When xice at a grid cell is smaller than a specified threshold, this grid cell is treated as a water point (swe=0, snowh=0, snowc=0)
However, xice ==0 over land. When using the above approach to determine snow, we mistakenly remove snow from land areas.
The present PR fixes the mistake and results are reasonable.