Skip to content

glcanon: Fix variable name mismatch and comparison to show tool cone #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andypugh merged 1 commit into from
Apr 30, 2026
+2 −2
Merged

glcanon: Fix variable name mismatch and comparison to show tool cone #3989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/python/rs274/glcanon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ def __init__(self, s=None, lp=None, g=None):
self.max_file_size = temp * 1024 * 1024

self.disable_cone_scaling = self.inifile.getbool("DISPLAY", "DISABLE_CONE_SCALING", fallback=False)
self.tool_min_dia = self.inifile.getreal("DISPLAY", "GCODE_VIEW_TOOL_MIN_DIA", fallback=0.0)
self.view_tool_min_dia = self.inifile.getreal("DISPLAY", "GCODE_VIEW_TOOL_MIN_DIA", fallback=0.0)

except:
# Probably started in an editor so no INI
Expand Down Expand Up @@ -1498,7 +1498,7 @@ def redraw(self):
glBlendFunc(GL_ONE, GL_CONSTANT_ALPHA)

current_tool = self.get_current_tool()
if current_tool is None or current_tool.diameter < self.view_tool_min_dia:
if current_tool is None or current_tool.diameter <= self.view_tool_min_dia:
if self.canon and not self.disable_cone_scaling:
g = self.canon

Expand Down
Loading