probe_error_decel_no_inhibit rebased for 2.9#3537
Conversation
|
I want to run this on my mill (where I see the problem) before commiting. It might take me a few days to find the time. |
|
That's great Andy, thanks so much! |
|
I found the time to find that my mill is broken. I spent this evening on it and it's close to working now. |
|
I finally got my mill back up and running, and tested this. |
|
Thanks for getting deep into this. It had been causing me trouble for some time, and I was thinking it was something wrong in my setup that I didn't have the time to fix. Finding that it was an inherent problem in the logic is an important improvement. |
|
Excellent, thanks so much! I'm really glad this got into 2.9.5! It's still possible to get bounce on the pulloff move if it's not a probing move, but it's less likely and the error message when this happens is accurate (the probe has tripped during a non-probe move), so most people will find that the bounce issue is no longer a problem that requires hal logic to fix. But, if you make the pulloff move a probing move as well (G38.4 or G38.5), it will also be bounce-tolerant during deceleration. Also, #3534 (the original pull request against master which is dated compared the logic eventually merged into 2.9) is still open, shall I close that now? |
This is the bugfix for the probe deceleration error, rebased for the 2.9 branch.
The current state of this pull request is based on discussion from my previous pull request into master:
#3534
The previous pull request kept the original behaviour (with the deceleration error) by default, but also included the ability to inhibit the error.
However, in this pull request the error is effectively permanently inhibited (so, fully patched) with no option to enable it, due to the determination that this error is definitely a bug which should be fully patched).