Skip to content

probe_error_decel_no_inhibit rebased for 2.9#3537

Merged
andypugh merged 1 commit intoLinuxCNC:2.9from
DauntlessAq:probe_error_decel_no_inhibit_2.9
Aug 27, 2025
Merged

probe_error_decel_no_inhibit rebased for 2.9#3537
andypugh merged 1 commit intoLinuxCNC:2.9from
DauntlessAq:probe_error_decel_no_inhibit_2.9

Conversation

@DauntlessAq
Copy link
Copy Markdown
Contributor

This is the bugfix for the probe deceleration error, rebased for the 2.9 branch.

The current state of this pull request is based on discussion from my previous pull request into master:
#3534

The previous pull request kept the original behaviour (with the deceleration error) by default, but also included the ability to inhibit the error.

However, in this pull request the error is effectively permanently inhibited (so, fully patched) with no option to enable it, due to the determination that this error is definitely a bug which should be fully patched).

@andypugh
Copy link
Copy Markdown
Collaborator

andypugh commented Aug 7, 2025

I want to run this on my mill (where I see the problem) before commiting. It might take me a few days to find the time.

@DauntlessAq
Copy link
Copy Markdown
Contributor Author

That's great Andy, thanks so much!

@andypugh
Copy link
Copy Markdown
Collaborator

I found the time to find that my mill is broken. I spent this evening on it and it's close to working now.
I won't be releasing 2.9.5 until this is in, so it's not going to miss any deadlines.

@andypugh
Copy link
Copy Markdown
Collaborator

I finally got my mill back up and running, and tested this.
The existing 2.9.4 installation errored out on my testing about half the time, whereas with the new logic it did 10 consecutive tests without any issue.

@andypugh andypugh merged commit 88ef1d5 into LinuxCNC:2.9 Aug 27, 2025
17 checks passed
@andypugh
Copy link
Copy Markdown
Collaborator

Thanks for getting deep into this. It had been causing me trouble for some time, and I was thinking it was something wrong in my setup that I didn't have the time to fix. Finding that it was an inherent problem in the logic is an important improvement.

@DauntlessAq
Copy link
Copy Markdown
Contributor Author

Excellent, thanks so much! I'm really glad this got into 2.9.5!
Hoping this will save a lot of frustration for people setting up probing.

It's still possible to get bounce on the pulloff move if it's not a probing move, but it's less likely and the error message when this happens is accurate (the probe has tripped during a non-probe move), so most people will find that the bounce issue is no longer a problem that requires hal logic to fix.

But, if you make the pulloff move a probing move as well (G38.4 or G38.5), it will also be bounce-tolerant during deceleration.
Since I'm assuming the majority of users probe using prewritten macros, if these macros are modified to take advantage of this change, it should be possible to effectively completely eliminate the bounce issue for these users, making it a completely solved issue for the majority.

Also, #3534 (the original pull request against master which is dated compared the logic eventually merged into 2.9) is still open, shall I close that now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants