probe_error_decel_no_inhibit - rebased for 2.9#3536
Closed
DauntlessAq wants to merge 1 commit intoLinuxCNC:masterfrom
Closed
probe_error_decel_no_inhibit - rebased for 2.9#3536DauntlessAq wants to merge 1 commit intoLinuxCNC:masterfrom
DauntlessAq wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
Contributor
Author
|
(accidentally opened request against master - closed and resubmitting against 2.9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the bugfix for the probe deceleration error, rebased for the 2.9 branch.
The current state of this pull request is based on discussion from my previous pull request into master:
#3534
The previous pull request kept the original behaviour (with the deceleration error) by default, but also included the ability to inhibit the error.
However, in this pull request the error is effectively permanently inhibited (so, fully patched) with no option to enable it, due to the determination that this error is definitely a bug which should be fully patched).