Jinjava 3.0: Roll back some of the unnecessary breaking changes#1316
Open
jasmith-hs wants to merge 5 commits intomasterfrom
Open
Jinjava 3.0: Roll back some of the unnecessary breaking changes#1316jasmith-hs wants to merge 5 commits intomasterfrom
jasmith-hs wants to merge 5 commits intomasterfrom
Conversation
eager execution output template string itself is backwards compatible with Jinjava 2.8.x
rewaddell
approved these changes
Apr 24, 2026
The |reverse filter in Jinja returns an iterator, but Jinjava 2 returned
a list. The ReverseArrayIterator introduced in 3.0 breaks non-standard
usage like {{ (arr|reverse)[0] }}. This override (enabled in THREE_POINT_0)
keeps the iterator behavior; when disabled, the result is collected into
a list for backwards compatibility.
Also fixes Builder.from() which was missing keepNullableLoopValues, causing
it to silently reset to false when cloning a LegacyOverrides instance.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rewaddell
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be some binary incompatibility issues with how I migrated JinjavaConfig to an immutable and LegacyOverrides to an Immutable.
The JinjavaConfig migration binary incompatibility can be solved by having JinjavaConfig remain a class so that the reference to
JinjavaConfig#newBuilderremains a class method reference rather than an interface method reference.I could not keep LegacyOverrides as an immutable, and had to revert it back to being a POJO. Trying to solve the interface method reference backwards incompatibility issue by making it a class could introduce a static class initialization deadlock due to the static members like
LegacyOverrides.NONEreferencing a subclass ofLegacyOverrides(ImmutableLegacyOverrides)I kept it so that eager execution will continue to reconstruct the
JinjavaInterpreterarguments as____int3rpr3t3r____rather thannullso that if needing to revert an upgrade to Jinjava 3.0, there won't have been any first-phase eager execution outputs that are backwards incompatible (as resolvingnullfor exptests and filters in Jinjava 2.8.X would break them). This does not decrease the security of Jinjava 3.0 because I'm still not resolving the____int3rpr3t3r____variable ever, it is still resolved tonull