Skip to content

sorbet: Make tests typed: false#21867

Merged
issyl0 merged 1 commit intomainfrom
rspec-sorbet-typed
Mar 30, 2026
Merged

sorbet: Make tests typed: false#21867
issyl0 merged 1 commit intomainfrom
rspec-sorbet-typed

Conversation

@issyl0
Copy link
Copy Markdown
Member

@issyl0 issyl0 commented Mar 29, 2026


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

  • Now that we've enabled --experimental-rspec-mode1, let's start using Sorbet in tests at its basic typed: false level for now.
  • This will ease the migration to typed: true of any or all tests we want to do in the future.

Copilot AI review requested due to automatic review settings March 29, 2026 15:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Sorbet headers in the test suite by marking test files as typed: false, establishing a baseline for future gradual typing adoption under --experimental-rspec-mode.

Changes:

  • Add # typed: false Sorbet sigil to RSpec test files.
  • Keep existing # frozen_string_literal: true headers intact, with Sorbet sigil placed first.
  • Apply this consistently across unit, integration/system, and shared-example spec/support files.

Reviewed changes

Copilot reviewed 300 out of 748 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Library/Homebrew/test/livecheck/livecheck_version_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/livecheck/livecheck_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/linux_runner_spec_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/linkage_cache_store_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/lazy_object_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/python_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/python/virtualenv_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/python/shebang_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/php/shebang_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/perl/shebang_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/node_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/node/shebang_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/language/java_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_relocate/text_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_relocate/relocation_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_relocate/grep_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_relocate/binary_relocation_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/keg_only_reason_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/installed_dependents_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/homebrew_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/head_software_spec_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/hardware/cpu_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/global_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/github_runner_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/github_runner_matrix_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/git_repository_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/free_port_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formulary_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_validation_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_spec_selection_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_pin_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_installer_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_installer_bottle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_info_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_creator_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formula_auditor_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/formatter_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/extend/pathname/write_mkpath_extension_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/extend/kernel_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/extend/blank_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/extend/array_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/exceptions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/error_during_execution_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/env_config_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/vcs_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/subversion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/github_git_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/git_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/detector_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/curl_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/curl_post_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/curl_github_packages_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/download_strategies/abstract_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/diagnostic_checks_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/which-update_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/verify_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/vendor-gems_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-test_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-sponsors_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-python-resources_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-perl-resources_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-maintainers_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/update-license-data_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/unpack_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/unbottled_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/typecheck_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/tests_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/test_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/tap-new_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/style_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/sh_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/ruby_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/release_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/prof_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/pr-upload_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/pr-pull_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/pr-publish_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/pr-automerge_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/livecheck_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/linkage_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/lgtm_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/irb_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/install-bundler-gems_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-zap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-man-completions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-formula-api_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-cask-api_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/generate-analytics-api_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/formula_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/formula-analytics_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/extract_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/edit_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/dispatch-build-bottle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/determine-test-runners_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/create_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/contributions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/cat_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bump_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bump-unversioned-casks_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bump-revision_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bump-formula-pr_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bump-cask-pr_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/bottle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dev-cmd/audit_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/descriptions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/description_cache_store_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/deprecate_disable_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependency_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependency_expansion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependency_collector_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependencies_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependencies_helpers_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/dependable_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cxxstdlib_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/completions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/compiler_selector_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/compiler_failure_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/commands_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/which-formula_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/version-install_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/vendor-install_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/uses_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/upgrade_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/update-report_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/untap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/unpin_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/unlink_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/uninstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/unalias_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/tap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/tap-info_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/tab_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/source_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/shellenv_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/shared_examples/args_parse.rb Add Sorbet typed: false header to shared examples.
Library/Homebrew/test/cmd/setup-ruby_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/services_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/search_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/reinstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/readall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/rbenv-sync_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/pyenv-sync_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/postinstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/pin_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/outdated_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/options_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/nodenv-sync_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/missing_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/migrate_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/mcp-server_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/log_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/list_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/link_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/leaves_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/install_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/info_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/home_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/help_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/gist-logs_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/formulae_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/fetch_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/doctor_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/docs_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/developer_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/desc_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/deps_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/custom-external-command_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/config_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/completions_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/commands_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/command_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/command-not-found-init_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/cleanup_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/casks_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/bundle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/autoremove_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/analytics_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/alias_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--version_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--repository_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--prefix_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--env_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--cellar_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--caskroom_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cmd/--cache_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cli/parser_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cli/named_args_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cleanup_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cleaner_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/checksum_verification_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/checksum_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/caveats_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask_dependent_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/utils_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/upgrade_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/uninstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/tab_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/reinstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/pkg_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/migrator_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/macos_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/list_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/installer_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/info_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/version_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/uninstall_preflight_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/uninstall_postflight_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/shared_examples/staged.rb Add Sorbet typed: false header to shared examples.
Library/Homebrew/test/cask/dsl/shared_examples/base.rb Add Sorbet typed: false header to shared examples.
Library/Homebrew/test/cask/dsl/rename_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/preflight_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/postflight_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/container_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/dsl/caveats_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/download_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/depends_on_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/denylist_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/config_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader/from_uri_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader/from_tap_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader/from_path_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader/from_content_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/cask_loader/from_api_loader_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/audit_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/zshcompletion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/zap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/uninstall_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/uninstall_no_zap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/two_apps_correct_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/symlinked_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/suite_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/shared_examples/uninstall_zap.rb Add Sorbet typed: false header to shared examples.
Library/Homebrew/test/cask/artifact/relocated_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/preflight_block_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/postflight_block_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/pkg_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/manpage_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/installer_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/generic_artifact_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/generated_completion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/fishlcompletion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/binary_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/bashcompletion_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/app_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/alt_target_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cask/artifact/abstract_artifact_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/cache_store_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle_version_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/vscode_extension_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/uv_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/tap_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/skipper_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/remover_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/npm_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/mac_app_store_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/krew_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/installer_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/go_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/flatpak_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/dumper_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/dsl_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/remove_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/list_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/install_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/exec_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/dump_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/cleanup_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/check_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/commands/add_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/cask_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/cargo_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/bundle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/brewfile_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/brew_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bundle/brew_services_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bump_version_parser_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/build_options_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/build_environment_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bottle_specification_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bottle_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bottle_filename_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/bash_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/attestation_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/internal_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/formula_struct_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/formula_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/formula/formula_struct_generator_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/cask_struct_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/cask_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/api/cask/cask_struct_generator_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/abstract_command_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/PATH_spec.rb Add Sorbet typed: false header to test file.
Library/Homebrew/test/ENV_spec.rb Add Sorbet typed: false header to test file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Now that we've enabled `--experimental-rspec-mode` [1], let's start
  using Sorbet in tests at its basic `typed: false` level for now.
- This will ease the migration to `typed: true` of any or all tests we
  want to do in the future.

[1]: #21742
@issyl0 issyl0 force-pushed the rspec-sorbet-typed branch from 0949554 to f3fb592 Compare March 29, 2026 15:39
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@issyl0 issyl0 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 4b52e03 Mar 30, 2026
40 checks passed
@issyl0 issyl0 deleted the rspec-sorbet-typed branch March 30, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants