Fixed AVR include#3
Open
nobodyguy wants to merge 1 commit into
Open
Conversation
Without this fix compilation failed for non-AVR MCUs.
Owner
|
Thanks for your input. The purpose of the #else is to include the avr/dtostrf.h for non-AVR MCUs. I've tested it with ESP8266/ESP32 but it seems from your suggested fix it is causing a problem with other(?) MCU(s). Could you let me know what MCU and version of IDE you are complaining it for so I can try to replicate your issue? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix compilation failed for non-AVR MCUs.