-
Notifications
You must be signed in to change notification settings - Fork 6.7k
How many jobs to list in Dataflow tests #6094
Copy link
Copy link
Closed
Labels
api: dataflowIssues related to the Dataflow API.Issues related to the Dataflow API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Metadata
Metadata
Assignees
Labels
api: dataflowIssues related to the Dataflow API.Issues related to the Dataflow API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Describe the issue
For Dataflow tests, in
dataflow_job_id_from_job_name,to get the job ID from a job name, we're currently listing only the latest 50 active jobs.
Currently this is hardcoded to 50, which should be enough for most cases. Right now, there aren't any tests using this function so it shouldn't be an issue. At this point, we could safely remove this function.
For more information, see #5692 (comment)