Skip to content

Cleanup: remove deprecated BlackListManager, unify HttpClient via IHttpClientFactory, deduplicate IPC encryption#420

Merged
JusterZhu merged 1 commit into
masterfrom
cleanup/blacklist-httpclient-ipc
May 25, 2026
Merged

Cleanup: remove deprecated BlackListManager, unify HttpClient via IHttpClientFactory, deduplicate IPC encryption#420
JusterZhu merged 1 commit into
masterfrom
cleanup/blacklist-httpclient-ipc

Conversation

@JusterZhu
Copy link
Copy Markdown
Collaborator

Closes #419

Changes

1. Remove deprecated BlackListManager

  • Deleted BlackListManager obsolete singleton
  • Extracted IBlackListMatcher interface into own file
  • Removed ?? BlackListManager.Instance fallback in StorageManager

2. Unify HttpClient with IHttpClientFactory

  • Added Microsoft.Extensions.Http package (all 3 TFMs)
  • New HttpClientFactoryProvider - lazy singleton wrapping ServiceCollection to IHttpClientFactory
  • Replaced all new HttpClient() in strategies with factory CreateClient
  • Removed manual Dispose calls; replaced Timeout with CancellationTokenSource

3. Deduplicate IPC encryption

  • New IpcEncryption - shared AES encrypt/decrypt utility
  • Refactored Environments and EncryptedFileProcessInfoProvider to use it
  • Fixed file name typo: Muti to Multi (4 event args)
  • Deleted stale net9.0 bin/obj and ConfiginfoBuilder-Example.cs

Build: passes (0 errors)

Copilot AI review requested due to automatic review settings May 25, 2026 13:08
… instance, deduplicate IPC encryption

- Delete deprecated BlackListManager singleton, extract IBlackListMatcher to own file
- Add HttpClientProvider with static shared HttpClient (no DI dependency)
- Replace all new HttpClient() with HttpClientProvider.Shared
- Extract IpcEncryption shared AES utility used by Environments and IProcessInfoProvider
- Fix Muti -> Multi file name typo (4 event args)
- Delete stale net9.0 bin/obj and ConfiginfoBuilder-Example.cs

Closes #419
@JusterZhu JusterZhu force-pushed the cleanup/blacklist-httpclient-ipc branch from f948ea9 to f6f2e8d Compare May 25, 2026 13:12
@JusterZhu JusterZhu merged commit 31fa9b1 into master May 25, 2026
1 of 3 checks passed
@JusterZhu JusterZhu deleted the cleanup/blacklist-httpclient-ipc branch May 25, 2026 13:13
JusterZhu added a commit that referenced this pull request May 25, 2026
Restore all modified files from 7c3d702 and reapply:
- BlackListManager removal (StorageManager, BlackListDefaults)
- HttpClientProvider.Shared in strategies
- IpcEncryption delegates in Environments, IProcessInfoProvider
- IBlackListMatcher extracted to own file
- Muti->Multi file rename
- Delete ConfiginfoBuilder-Example.cs

Closes #419
@JusterZhu JusterZhu review requested due to automatic review settings May 25, 2026 13:30
JusterZhu added a commit that referenced this pull request May 25, 2026
…ListManager references

- Restore all files from before #420 merge and re-apply changes with proper encoding
- Replace BlackListManager.Instance references in Differential project and tests
- Fix ParameterMatrixAndEventTests to work with DefaultBlackListMatcher API
- Use BlackListDefaults instead of removed BlackListManager singleton

All changes from #419 + CI build fixes. Build and tests pass.
JusterZhu added a commit that referenced this pull request May 25, 2026
Fix encoding corruption from #420 and cross-project BlackListManager references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: remove deprecated BlackListManager, unify HttpClient via IHttpClientFactory, deduplicate IPC encryption

1 participant