fix: address Copilot review suggestions from merged PRs#418
Merged
Conversation
- OSSUpdateStrategy: make DownloadVersionConfig truly async - DefaultDownloadOrchestrator: pass full DownloadAsset in failedDetails - DownloadResult.LocalPath: change from string? to string - Executors failure paths: return destPath instead of null for LocalPath
Contributor
There was a problem hiding this comment.
Pull request overview
Applies follow-up fixes to address Copilot review suggestions from PRs #414, #416, #417: makes an OSS download path truly async, propagates the full DownloadAsset in failed-download dispatch details, tightens DownloadResult.LocalPath to non-nullable, and returns destPath instead of null on executor failure.
Changes:
- Convert
DownloadVersionConfigto async and await it inExecuteClientAsync. - Pass full
DownloadAsset(instead of justUrl) infailedDetailsforDispatchAllCompleted. - Change
DownloadResult.LocalPathtostringand returndestPathon failure in HTTP/OSS executors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/c#/GeneralUpdate.Core/Strategy/OSSUpdateStrategy.cs | Makes DownloadVersionConfig async and awaits it with ConfigureAwait(false). |
| src/c#/GeneralUpdate.Core/Download/Orchestrators/DefaultDownloadOrchestrator.cs | Passes full DownloadAsset in failed-details tuple. |
| src/c#/GeneralUpdate.Core/Download/Models/DownloadProgress.cs | Tightens LocalPath to non-nullable string. |
| src/c#/GeneralUpdate.Core/Download/Executors/OssDownloadExecutor.cs | Returns destPath instead of null on failure. |
| src/c#/GeneralUpdate.Core/Download/Executors/HttpDownloadExecutor.cs | Returns destPath instead of null on failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for Copilot suggestions on #414, #416, #417: