Summary
GeneralUpdateBootstrap.LaunchAsync() bypasses the implemented OSSUpdateStrategy for the client-side OSS flow, calling LaunchOssAsync() directly. This creates two separate OSS code paths.
Current State
LaunchAsync() switch case: AppType.OSS => await LaunchOssAsync()
LaunchOssAsync() has its own version-check, download, and process-launch logic
OSSUpdateStrategy is fully implemented with hooks, reporter, and download orchestrator support but only triggered via the IPC path (when GlobalConfigInfoOSS env variable is set)
Expected
LaunchAsync() for OSS should go through LaunchWithStrategy(new OSSUpdateStrategy()) just like Client and Upgrade
- All OSS logic (version check, download, decompress, launch) lives in
OSSUpdateStrategy
- Delete
LaunchOssAsync() from GeneralUpdateBootstrap
- OSS path benefits from hooks, reporter, and download orchestrator like Client/Upgrade paths do
Benefits
- Single code path for OSS updates
- Consistent hooks + reporter invocation across all
AppType values
- Less maintenance burden
Ref
Refactoring plan v2: Section 2.3 (Target Architecture), Sub Issue 3 (Bootstrap Unification)
Summary
GeneralUpdateBootstrap.LaunchAsync()bypasses the implementedOSSUpdateStrategyfor the client-side OSS flow, callingLaunchOssAsync()directly. This creates two separate OSS code paths.Current State
LaunchAsync()switch case:AppType.OSS => await LaunchOssAsync()LaunchOssAsync()has its own version-check, download, and process-launch logicOSSUpdateStrategyis fully implemented with hooks, reporter, and download orchestrator support but only triggered via the IPC path (whenGlobalConfigInfoOSSenv variable is set)Expected
LaunchAsync()for OSS should go throughLaunchWithStrategy(new OSSUpdateStrategy())just like Client and UpgradeOSSUpdateStrategyLaunchOssAsync()fromGeneralUpdateBootstrapBenefits
AppTypevaluesRef
Refactoring plan v2: Section 2.3 (Target Architecture), Sub Issue 3 (Bootstrap Unification)