Skip to content

Terminology Cache#375

Merged
mpsonntag merged 6 commits into
G-Node:masterfrom
fschrader1992:rdf
Apr 12, 2020
Merged

Terminology Cache#375
mpsonntag merged 6 commits into
G-Node:masterfrom
fschrader1992:rdf

Conversation

@fschrader1992
Copy link
Copy Markdown
Collaborator

@fschrader1992 fschrader1992 commented Apr 3, 2020

This PR

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 3, 2020

Coverage Status

Coverage increased (+0.6%) to 76.383% when pulling c65ecaa on fschrader1992:rdf into d9d5223 on G-Node:master.

Copy link
Copy Markdown
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added cache function is useful, but #202 requires a full refresh of the cache.

Copy link
Copy Markdown
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, looks good otherwise, thanks!

Comment thread odml/terminology.py Outdated
@fschrader1992
Copy link
Copy Markdown
Collaborator Author

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Repeat Local Tests Python3.8
  • Repeat Local Tests Python2.7

@mpsonntag mpsonntag merged commit 7dde867 into G-Node:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comparison of odml objects [1.4] Terminology cache cannot be refreshed

5 participants