Skip to content

Validation Name and Property Tuple Extend#372

Merged
mpsonntag merged 16 commits into
G-Node:masterfrom
fschrader1992:validation
Mar 29, 2020
Merged

Validation Name and Property Tuple Extend#372
mpsonntag merged 16 commits into
G-Node:masterfrom
fschrader1992:validation

Conversation

@fschrader1992
Copy link
Copy Markdown
Collaborator

@fschrader1992 fschrader1992 commented Mar 26, 2020

This PR

@fschrader1992
[validation.py] Fix Wrong Error Message Variables Order for hasattr C…
56e12fe 
…heck
@fschrader1992
[validation.py] Add Object Name Readability Check
aaac777 
For Section and Property.
@fschrader1992
[test_validation.py] Add Test for Section Name Readability
13a51c8
@fschrader1992
[test_validation.py] Add Test for Property Name Readability
206b274
@fschrader1992
[test_validation.py] Fix Bad Continuation and Whitespace
6951184
@fschrader1992
[test_validation.py] Change Error Assertion for Load Section Tests
d3faa1f 
For xml, json and yaml.
@fschrader1992
[test_validation.py] Add Test for Section Init Validation Stdout
89a5536
@fschrader1992
[test_validation.py] Replace For Loop by Filter
8a58ce1
@fschrader1992
[test_fileio.py] Change Test File Path to example.odml
cd5084a 
Change to more robust way to access file location and
use file from within test dir.

Otherwise might not be found during local testing.
@fschrader1992
[property.py] Fix Tuple Extend Error
957dcda 
Because dtype always inferred as string.
@fschrader1992
[property.py] Fix Tuple Append Error
543dcd4 
Because dtype always inferred as string.
@fschrader1992
[test_property.py] Add Tuple Extend Test
132bcd1
@fschrader1992
[test_property.py] Add Tuple Append Test
e468a1f
@fschrader1992
[test_property.py] Fix Whitespace
a11fda9
@fschrader1992
[test_property.py] Fix Bad Line Continuation
b902a51
@fschrader1992
[test_property.py] Replace Append in Extend Test
1d8e055
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.07%) to 75.694% when pulling 1d8e055 on fschrader1992:validation into 7e9299e on G-Node:master.

@fschrader1992
Copy link
Copy Markdown
Collaborator Author

fschrader1992 commented Mar 26, 2020

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Repeat Local Tests Python3.8
  • Repeat Local Tests Python2.7

mpsonntag
mpsonntag approved these changes Mar 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks a lot!

Good catch with the append usage in the Property.extend tests!

Comment thread odml/validation.py
:param obj: odml.Section or odml.Property.
"""
if obj.name == obj.id:
yield ValidationError(obj, 'Name should be readable', LABEL_WARNING)
Copy link
Copy Markdown
Contributor

@mpsonntag mpsonntag Mar 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the message to "Name should be human readable" to make it clearer whats expected of the user; but we can change this at a later point in time.

@mpsonntag mpsonntag merged commit d9d5223 into G-Node:master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpsonntag mpsonntag mpsonntag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Validation] Check for readable odml object name content [Property] Exception on x-tuple Property extend or append

3 participants

@fschrader1992 @coveralls @mpsonntag