Skip to content

chore: node version update#6359

Draft
0xi4o wants to merge 7 commits intomainfrom
chore/node-version
Draft

chore: node version update#6359
0xi4o wants to merge 7 commits intomainfrom
chore/node-version

Conversation

@0xi4o
Copy link
Copy Markdown
Contributor

@0xi4o 0xi4o commented May 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Node.js version from 20 to 24 across the repository, including configuration files and Dockerfiles, and updates test mocks to prefix unused parameters with underscores. Feedback indicates that Node.js 24 is not yet released, which will cause build failures; it is recommended to use a stable version like Node 22 instead. Additionally, a missing ARG definition for ${NODE_VERSION} was identified in the Dockerfile runtime stage, which would lead to an invalid image name.

Comment thread .nvmrc
Comment thread Dockerfile
Comment thread docker/Dockerfile
Comment thread docker/Dockerfile
Comment thread package.json
Comment thread packages/server/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants