fix: test_unit_routers.py for ci/cd#7530
Open
SahilJat wants to merge 2 commits into
Open
Conversation
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7530 +/- ##
==========================================
- Coverage 98.47% 98.31% -0.16%
==========================================
Files 1400 1400
Lines 53036 52909 -127
==========================================
- Hits 52226 52017 -209
- Misses 810 892 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7368
Fixes flaky CI failures caused by inline
models.Modelsubclasses intest_unit_app_routers.pypolluting Django's apps registry.models.Modelsubclasses (AnalyticsModel,MyModel,MyModel1,MyModel2) from the parametrised test functions.mock.MagicMock()objects that expose_meta.app_label— the only attribute the router inspects.from django.db import modelsimport, replaced withfrom unittest import mock.allow_migratetest was already clean and required no changes.Root Cause:
The root cause was that defining a Django model class registers it permanently in the apps registry for the lifetime of the worker process. When tests ran with
app_label="app_analytics", the four model classes were permanently registered against the realapp_analyticsapp, causingmakemigrations --checkto find unmigrated models and Migrator teardown to fail withrelation "app_analytics_analyticsmodel" already existsacross multiple xdist workers.How did you test this code?
makemigrationstest no longer detects phantom models.DuplicateTableerrors.