feat: Add new url for roles master api keys#3154
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
+ Coverage 95.99% 96.10% +0.11%
==========================================
Files 1062 1059 -3
Lines 32265 32038 -227
==========================================
- Hits 30973 30791 -182
+ Misses 1292 1247 -45 ☔ View full report in Codecov by Sentry. |
novakzaballa
requested review from
a team,
matthewelwell and
zachaysan
and removed request for
a team
| path( | ||
| "api/v1/organisations/<int:organisation_pk>/roles-api-key/<str:prefix>/", | ||
| RolesbyMasterAPIPrefixViewSet.as_view({"get": "list"}), | ||
| name="roles_api_keys_by_prefix", | ||
| ), |
There was a problem hiding this comment.
why go with as_view here instead of adding to the router?
There was a problem hiding this comment.
The URL was updated and it was added to the router
zachaysan
left a comment
zachaysan
left a comment
There was a problem hiding this comment.
The code looks good so I approved it, but when are the view's tests going to be added?
This reverts commit d770399.
4 participants
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Add new URL for role's API keys.
GET: organisations/{organisation_pk}/roles-api-key/{prefix}/
Related with #3042 and https://github.com/Flagsmith/flagsmith-rbac/pull/14
How did you test this code?
The unit tests included in the RBAC PR: https://github.com/Flagsmith/flagsmith-rbac/pull/14