Add support for AppCheck, Analytics, and Functions sdks. #432
Closed
justjish wants to merge 25 commits into
Closed
Add support for AppCheck, Analytics, and Functions sdks. #432justjish wants to merge 25 commits into
justjish wants to merge 25 commits into
Conversation
Collaborator
|
Hi @sujishpatel thank you for your contribution! We really appreciate all of this work, but it is difficult for us to review a PR with so many different changes. Would you be up for breaking this apart into a few PRs and issues? My suggestion for breaking this into pieces is: Individual PRs
Please file an issue for discussion
Other
Thank you again for your hard work! If you can break your changes out into multiple PRs, we'll get them reviewed and merged as quickly as possible. |
Contributor
Author
|
will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useInitAppCheckuseAppCheckAppCheckProvideruseInitAnalyticsuseAnalyticsAnalyticsProvideruseInitFunctionsuseFunctionsFunctionsProviderdistfolder to exist in repo to allow users to useyarn add http://github.com/.../reactfire#[branch]... todo produce build during pre-commit check?Code Cleanup
getValue, getString, getBoolean...rather than just having duplicate code.objectValfrom rxfire for database//@ts-ignoreto//@ts-expect-errorCode sample
[TODO]