1.20.1/dev#79
Merged
Merged
Conversation
No guarantee that relativize() will work, and that just masks the actual SNBT load error, making debugging difficult. FTBTeam/FTB-Mods-Issues#645
Built-in FTBLibrary isFloat() method is buggy and unnecessary and will be removed in next major MC version FTBTeam/FTB-Mods-Issues#682
Scope for more tests to be written, but this gives some basic test coverage for SNBT handling and SNBT configs Include a gradle test run as part of CI process
Convert long <mod>:textures/A/B.png names to shortened <mod>:A/B names during discovery. This means later image lookup will use the texture atlases, and correctly handle things like animated textures (via standard .mcmeta files) FTBTeam/FTB-Mods-Issues#690
Allows "command:XXX" strings in FTB Quests image click actions to function correctly. FTBTeam/FTB-Mods-Issues#691
Pull common build scripts from mods-meta, use release-driven publishing
Quicker alternative to using F3+T
Equivalent to Forge's PlayerEvent.NameFormat, used by FTB Ranks and FTB Essentials to modify player's display name based on rank, nickname & recording/streaming status. Much cleaner than both mods using their own mixins, and easier to establish event order. If this event ends up in Fabric API in some form, this will go away.
Added new BaseScreen#setSizeProportional() method Made image select screen larger
Should be returning the x parameter, not 0. Return value is position of next place to draw at, based on width of drawn string.
Same as vanilla UI method
- made FluidConfig work properly - PanelScrollBar now auto-calculates its maxValue based on the panel's height and content height; calling setMaxValue() will throw an exception now
Don't cache an unmodified player display name if no event listeners actually ran. FTBTeam/FTB-Mods-Issues#748
Also allow running on MC 1.20
Make a couple of methods public, add an accessor for AtlasSpriteIcon id
Includes default fallback implementation using entity tags Will replace direct stages integration code in other mods (quests, chunks...)
Includes fallback (no-op) implementation. Actual implementations to be provided by mods.
On Fabric, it may not yet exist when creating a new world, since the Fabric server-starting event (via Architectury) happens earlier than the equivalent Forge event FTBTeam/FTB-Mods-Issues#867
Out of SelectFluidScreen, into ClientUtils. Useful for FTB Quests fluid icon rendering.
Otherwise, it gets run multiple times, since all groups have their save() method called.
Like the existing read/write methods but throw an IOException instead of just returning false.
Not used by anything yet
8x8 textures force a mipmap level limitation to 3, which is not good FTBTeam/FTB-Mods-Issues#1055
MichaelHillcox
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not as massive as it looks, nearly all of these changes have already been merged to
mainThis PR brings
1.20.1/mainup to date. Any subsequent merges tomainwill be for 1.20.4 dev.