Fix NPE in PayloadDispatcherImpl#11196
Fix NPE in PayloadDispatcherImpl#11196gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adeb586cea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065111
Total [baseline] (11.133 s) : 0, 11132877
Agent [candidate] (1.068 s) : 0, 1067516
Total [candidate] (11.064 s) : 0, 11063622
section appsec
Agent [baseline] (1.27 s) : 0, 1269516
Total [baseline] (11.141 s) : 0, 11141038
Agent [candidate] (1.27 s) : 0, 1269875
Total [candidate] (11.126 s) : 0, 11125599
section iast
Agent [baseline] (1.243 s) : 0, 1242698
Total [baseline] (11.427 s) : 0, 11427365
Agent [candidate] (1.244 s) : 0, 1244230
Total [candidate] (11.306 s) : 0, 11306367
section profiling
Agent [baseline] (1.191 s) : 0, 1191413
Total [baseline] (11.005 s) : 0, 11004627
Agent [candidate] (1.19 s) : 0, 1189956
Total [candidate] (11.062 s) : 0, 11061648
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.282 ms) : 0, 1282
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (640.324 ms) : 0, 640324
BytebuddyAgent [candidate] (642.549 ms) : 0, 642549
AgentMeter [baseline] (29.599 ms) : 0, 29599
AgentMeter [candidate] (29.794 ms) : 0, 29794
GlobalTracer [baseline] (250.515 ms) : 0, 250515
GlobalTracer [candidate] (251.31 ms) : 0, 251310
AppSec [baseline] (32.497 ms) : 0, 32497
AppSec [candidate] (32.41 ms) : 0, 32410
Debugger [baseline] (60.683 ms) : 0, 60683
Debugger [candidate] (60.764 ms) : 0, 60764
Remote Config [baseline] (613.756 µs) : 0, 614
Remote Config [candidate] (610.297 µs) : 0, 610
Telemetry [baseline] (8.058 ms) : 0, 8058
Telemetry [candidate] (8.141 ms) : 0, 8141
Flare Poller [baseline] (5.164 ms) : 0, 5164
Flare Poller [candidate] (4.338 ms) : 0, 4338
section appsec
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (679.943 ms) : 0, 679943
BytebuddyAgent [candidate] (679.28 ms) : 0, 679280
AgentMeter [baseline] (12.301 ms) : 0, 12301
AgentMeter [candidate] (12.353 ms) : 0, 12353
GlobalTracer [baseline] (250.135 ms) : 0, 250135
GlobalTracer [candidate] (251.234 ms) : 0, 251234
IAST [baseline] (24.348 ms) : 0, 24348
IAST [candidate] (24.422 ms) : 0, 24422
AppSec [baseline] (187.058 ms) : 0, 187058
AppSec [candidate] (187.647 ms) : 0, 187647
Debugger [baseline] (66.125 ms) : 0, 66125
Debugger [candidate] (65.14 ms) : 0, 65140
Remote Config [baseline] (621.067 µs) : 0, 621
Remote Config [candidate] (596.779 µs) : 0, 597
Telemetry [baseline] (7.822 ms) : 0, 7822
Telemetry [candidate] (7.93 ms) : 0, 7930
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.47 ms) : 0, 3470
section iast
crashtracking [baseline] (1.243 ms) : 0, 1243
crashtracking [candidate] (1.243 ms) : 0, 1243
BytebuddyAgent [baseline] (818.386 ms) : 0, 818386
BytebuddyAgent [candidate] (818.668 ms) : 0, 818668
AgentMeter [baseline] (11.425 ms) : 0, 11425
AgentMeter [candidate] (11.467 ms) : 0, 11467
GlobalTracer [baseline] (239.492 ms) : 0, 239492
GlobalTracer [candidate] (241.222 ms) : 0, 241222
IAST [baseline] (30.829 ms) : 0, 30829
IAST [candidate] (30.999 ms) : 0, 30999
AppSec [baseline] (26.822 ms) : 0, 26822
AppSec [candidate] (27.675 ms) : 0, 27675
Debugger [baseline] (66.407 ms) : 0, 66407
Debugger [candidate] (64.872 ms) : 0, 64872
Remote Config [baseline] (536.788 µs) : 0, 537
Remote Config [candidate] (533.972 µs) : 0, 534
Telemetry [baseline] (7.781 ms) : 0, 7781
Telemetry [candidate] (7.783 ms) : 0, 7783
Flare Poller [baseline] (3.461 ms) : 0, 3461
Flare Poller [candidate] (3.432 ms) : 0, 3432
section profiling
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (696.062 ms) : 0, 696062
BytebuddyAgent [candidate] (695.815 ms) : 0, 695815
AgentMeter [baseline] (8.94 ms) : 0, 8940
AgentMeter [candidate] (8.941 ms) : 0, 8941
GlobalTracer [baseline] (208.772 ms) : 0, 208772
GlobalTracer [candidate] (208.393 ms) : 0, 208393
AppSec [baseline] (32.694 ms) : 0, 32694
AppSec [candidate] (32.639 ms) : 0, 32639
Debugger [baseline] (66.038 ms) : 0, 66038
Debugger [candidate] (65.712 ms) : 0, 65712
Remote Config [baseline] (575.551 µs) : 0, 576
Remote Config [candidate] (574.773 µs) : 0, 575
Telemetry [baseline] (7.706 ms) : 0, 7706
Telemetry [candidate] (7.776 ms) : 0, 7776
Flare Poller [baseline] (3.469 ms) : 0, 3469
Flare Poller [candidate] (3.485 ms) : 0, 3485
ProfilingAgent [baseline] (93.79 ms) : 0, 93790
ProfilingAgent [candidate] (93.903 ms) : 0, 93903
Profiling [baseline] (94.353 ms) : 0, 94353
Profiling [candidate] (94.46 ms) : 0, 94460
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060490
Total [baseline] (8.821 s) : 0, 8820995
Agent [candidate] (1.055 s) : 0, 1054791
Total [candidate] (8.875 s) : 0, 8874753
section iast
Agent [baseline] (1.238 s) : 0, 1237667
Total [baseline] (9.549 s) : 0, 9548793
Agent [candidate] (1.228 s) : 0, 1228351
Total [candidate] (9.519 s) : 0, 9518810
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.251 ms) : 0, 1251
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (638.898 ms) : 0, 638898
BytebuddyAgent [candidate] (634.69 ms) : 0, 634690
AgentMeter [baseline] (29.603 ms) : 0, 29603
AgentMeter [candidate] (29.422 ms) : 0, 29422
GlobalTracer [baseline] (249.942 ms) : 0, 249942
GlobalTracer [candidate] (248.463 ms) : 0, 248463
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.265 ms) : 0, 32265
Debugger [baseline] (59.892 ms) : 0, 59892
Debugger [candidate] (59.566 ms) : 0, 59566
Remote Config [baseline] (597.555 µs) : 0, 598
Remote Config [candidate] (602.875 µs) : 0, 603
Telemetry [baseline] (7.98 ms) : 0, 7980
Telemetry [candidate] (8.826 ms) : 0, 8826
Flare Poller [baseline] (3.585 ms) : 0, 3585
Flare Poller [candidate] (3.571 ms) : 0, 3571
section iast
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (815.024 ms) : 0, 815024
BytebuddyAgent [candidate] (807.533 ms) : 0, 807533
AgentMeter [baseline] (11.432 ms) : 0, 11432
AgentMeter [candidate] (11.357 ms) : 0, 11357
GlobalTracer [baseline] (239.783 ms) : 0, 239783
GlobalTracer [candidate] (238.391 ms) : 0, 238391
IAST [baseline] (31.061 ms) : 0, 31061
IAST [candidate] (29.094 ms) : 0, 29094
AppSec [baseline] (29.113 ms) : 0, 29113
AppSec [candidate] (30.194 ms) : 0, 30194
Debugger [baseline] (62.075 ms) : 0, 62075
Debugger [candidate] (62.838 ms) : 0, 62838
Remote Config [baseline] (537.948 µs) : 0, 538
Remote Config [candidate] (596.577 µs) : 0, 597
Telemetry [baseline] (7.703 ms) : 0, 7703
Telemetry [candidate] (7.698 ms) : 0, 7698
Flare Poller [baseline] (3.443 ms) : 0, 3443
Flare Poller [candidate] (3.415 ms) : 0, 3415
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 23 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section baseline
no_agent (19.246 ms) : 19046, 19446
. : milestone, 19246,
appsec (18.621 ms) : 18434, 18808
. : milestone, 18621,
code_origins (18.86 ms) : 18671, 19049
. : milestone, 18860,
iast (17.914 ms) : 17733, 18094
. : milestone, 17914,
profiling (18.307 ms) : 18124, 18490
. : milestone, 18307,
tracing (19.2 ms) : 19008, 19393
. : milestone, 19200,
section candidate
no_agent (18.155 ms) : 17966, 18344
. : milestone, 18155,
appsec (19.806 ms) : 19601, 20010
. : milestone, 19806,
code_origins (17.679 ms) : 17506, 17852
. : milestone, 17679,
iast (18.129 ms) : 17944, 18314
. : milestone, 18129,
profiling (18.376 ms) : 18191, 18560
. : milestone, 18376,
tracing (17.606 ms) : 17435, 17776
. : milestone, 17606,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section baseline
no_agent (1.248 ms) : 1236, 1261
. : milestone, 1248,
iast (3.348 ms) : 3300, 3396
. : milestone, 3348,
iast_FULL (6.168 ms) : 6105, 6231
. : milestone, 6168,
iast_GLOBAL (3.595 ms) : 3537, 3653
. : milestone, 3595,
profiling (2.161 ms) : 2140, 2181
. : milestone, 2161,
tracing (1.877 ms) : 1862, 1893
. : milestone, 1877,
section candidate
no_agent (1.263 ms) : 1250, 1275
. : milestone, 1263,
iast (3.218 ms) : 3173, 3262
. : milestone, 3218,
iast_FULL (5.974 ms) : 5914, 6034
. : milestone, 5974,
iast_GLOBAL (3.647 ms) : 3585, 3710
. : milestone, 3647,
profiling (2.34 ms) : 2313, 2367
. : milestone, 2340,
tracing (1.922 ms) : 1904, 1941
. : milestone, 1922,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section baseline
no_agent (1.493 ms) : 1481, 1504
. : milestone, 1493,
appsec (3.769 ms) : 3550, 3987
. : milestone, 3769,
iast (2.285 ms) : 2215, 2355
. : milestone, 2285,
iast_GLOBAL (2.333 ms) : 2263, 2403
. : milestone, 2333,
profiling (2.107 ms) : 2052, 2162
. : milestone, 2107,
tracing (2.101 ms) : 2047, 2155
. : milestone, 2101,
section candidate
no_agent (1.493 ms) : 1481, 1505
. : milestone, 1493,
appsec (2.544 ms) : 2489, 2598
. : milestone, 2544,
iast (2.286 ms) : 2217, 2356
. : milestone, 2286,
iast_GLOBAL (2.329 ms) : 2260, 2399
. : milestone, 2329,
profiling (2.116 ms) : 2060, 2172
. : milestone, 2116,
tracing (2.086 ms) : 2032, 2139
. : milestone, 2086,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~577c0766d4, baseline=1.62.0-SNAPSHOT~7c1b47b5d5
dateFormat X
axisFormat %s
section baseline
no_agent (15.704 s) : 15704000, 15704000
. : milestone, 15704000,
appsec (14.614 s) : 14614000, 14614000
. : milestone, 14614000,
iast (18.2 s) : 18200000, 18200000
. : milestone, 18200000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
. : milestone, 18036000,
profiling (15.503 s) : 15503000, 15503000
. : milestone, 15503000,
tracing (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
section candidate
no_agent (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
appsec (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
iast (18.631 s) : 18631000, 18631000
. : milestone, 18631000,
iast_GLOBAL (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
profiling (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
tracing (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Fixes:
Since
mapperandpackerare set on the same codePath, hence they need both to be nullCheckedMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.