Fix REASON-9: empty allocations returns DEFAULT instead of GENERAL error#11193
Draft
Fix REASON-9: empty allocations returns DEFAULT instead of GENERAL error#11193
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064631
Total [baseline] (8.834 s) : 0, 8833822
Agent [candidate] (1.055 s) : 0, 1054824
Total [candidate] (8.806 s) : 0, 8806456
section iast
Agent [baseline] (1.246 s) : 0, 1245516
Total [baseline] (9.576 s) : 0, 9575986
Agent [candidate] (1.237 s) : 0, 1237039
Total [candidate] (9.557 s) : 0, 9557410
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (642.994 ms) : 0, 642994
BytebuddyAgent [candidate] (634.878 ms) : 0, 634878
AgentMeter [baseline] (29.541 ms) : 0, 29541
AgentMeter [candidate] (29.418 ms) : 0, 29418
GlobalTracer [baseline] (249.477 ms) : 0, 249477
GlobalTracer [candidate] (248.283 ms) : 0, 248283
AppSec [baseline] (32.444 ms) : 0, 32444
AppSec [candidate] (32.364 ms) : 0, 32364
Debugger [baseline] (59.752 ms) : 0, 59752
Debugger [candidate] (59.53 ms) : 0, 59530
Remote Config [baseline] (607.007 µs) : 0, 607
Remote Config [candidate] (610.249 µs) : 0, 610
Telemetry [baseline] (7.986 ms) : 0, 7986
Telemetry [candidate] (7.998 ms) : 0, 7998
Flare Poller [baseline] (4.301 ms) : 0, 4301
Flare Poller [candidate] (4.41 ms) : 0, 4410
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (820.516 ms) : 0, 820516
BytebuddyAgent [candidate] (813.372 ms) : 0, 813372
AgentMeter [baseline] (11.556 ms) : 0, 11556
AgentMeter [candidate] (11.437 ms) : 0, 11437
GlobalTracer [baseline] (240.968 ms) : 0, 240968
GlobalTracer [candidate] (239.674 ms) : 0, 239674
AppSec [baseline] (31.691 ms) : 0, 31691
AppSec [candidate] (31.452 ms) : 0, 31452
Debugger [baseline] (64.746 ms) : 0, 64746
Debugger [candidate] (64.064 ms) : 0, 64064
Remote Config [baseline] (533.598 µs) : 0, 534
Remote Config [candidate] (541.123 µs) : 0, 541
Telemetry [baseline] (7.809 ms) : 0, 7809
Telemetry [candidate] (7.94 ms) : 0, 7940
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.539 ms) : 0, 3539
IAST [baseline] (26.741 ms) : 0, 26741
IAST [candidate] (27.661 ms) : 0, 27661
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054724
Total [baseline] (11.027 s) : 0, 11027082
Agent [candidate] (1.058 s) : 0, 1058078
Total [candidate] (11.008 s) : 0, 11008172
section appsec
Agent [baseline] (1.264 s) : 0, 1264381
Total [baseline] (11.089 s) : 0, 11089008
Agent [candidate] (1.259 s) : 0, 1259193
Total [candidate] (11.064 s) : 0, 11063594
section iast
Agent [baseline] (1.234 s) : 0, 1233723
Total [baseline] (11.189 s) : 0, 11189145
Agent [candidate] (1.235 s) : 0, 1234652
Total [candidate] (11.299 s) : 0, 11299161
section profiling
Agent [baseline] (1.192 s) : 0, 1191971
Total [baseline] (11.026 s) : 0, 11025857
Agent [candidate] (1.186 s) : 0, 1186172
Total [candidate] (10.996 s) : 0, 10996195
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (633.201 ms) : 0, 633201
BytebuddyAgent [candidate] (636.613 ms) : 0, 636613
AgentMeter [baseline] (29.355 ms) : 0, 29355
AgentMeter [candidate] (29.374 ms) : 0, 29374
GlobalTracer [baseline] (248.572 ms) : 0, 248572
GlobalTracer [candidate] (249.026 ms) : 0, 249026
AppSec [baseline] (32.076 ms) : 0, 32076
AppSec [candidate] (32.354 ms) : 0, 32354
Debugger [baseline] (60.356 ms) : 0, 60356
Debugger [candidate] (60.373 ms) : 0, 60373
Remote Config [baseline] (601.72 µs) : 0, 602
Remote Config [candidate] (598.087 µs) : 0, 598
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.778 ms) : 0, 8778
Flare Poller [baseline] (4.376 ms) : 0, 4376
Flare Poller [candidate] (3.565 ms) : 0, 3565
section appsec
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (676.007 ms) : 0, 676007
BytebuddyAgent [candidate] (673.396 ms) : 0, 673396
AgentMeter [baseline] (12.226 ms) : 0, 12226
AgentMeter [candidate] (12.194 ms) : 0, 12194
GlobalTracer [baseline] (249.912 ms) : 0, 249912
GlobalTracer [candidate] (248.385 ms) : 0, 248385
AppSec [baseline] (187.207 ms) : 0, 187207
AppSec [candidate] (185.628 ms) : 0, 185628
Debugger [baseline] (65.031 ms) : 0, 65031
Debugger [candidate] (66.068 ms) : 0, 66068
Remote Config [baseline] (579.727 µs) : 0, 580
Remote Config [candidate] (590.101 µs) : 0, 590
Telemetry [baseline] (7.874 ms) : 0, 7874
Telemetry [candidate] (7.889 ms) : 0, 7889
Flare Poller [baseline] (3.449 ms) : 0, 3449
Flare Poller [candidate] (3.463 ms) : 0, 3463
IAST [baseline] (24.457 ms) : 0, 24457
IAST [candidate] (24.159 ms) : 0, 24159
section iast
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (810.526 ms) : 0, 810526
BytebuddyAgent [candidate] (811.804 ms) : 0, 811804
AgentMeter [baseline] (11.364 ms) : 0, 11364
AgentMeter [candidate] (11.418 ms) : 0, 11418
GlobalTracer [baseline] (239.11 ms) : 0, 239110
GlobalTracer [candidate] (239.177 ms) : 0, 239177
AppSec [baseline] (29.552 ms) : 0, 29552
AppSec [candidate] (27.715 ms) : 0, 27715
Debugger [baseline] (66.388 ms) : 0, 66388
Debugger [candidate] (65.382 ms) : 0, 65382
Remote Config [baseline] (549.945 µs) : 0, 550
Remote Config [candidate] (532.232 µs) : 0, 532
Telemetry [baseline] (7.827 ms) : 0, 7827
Telemetry [candidate] (7.733 ms) : 0, 7733
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.477 ms) : 0, 3477
IAST [baseline] (27.537 ms) : 0, 27537
IAST [candidate] (30.133 ms) : 0, 30133
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (697.125 ms) : 0, 697125
BytebuddyAgent [candidate] (692.989 ms) : 0, 692989
AgentMeter [baseline] (8.969 ms) : 0, 8969
AgentMeter [candidate] (9.025 ms) : 0, 9025
GlobalTracer [baseline] (208.875 ms) : 0, 208875
GlobalTracer [candidate] (207.568 ms) : 0, 207568
AppSec [baseline] (32.8 ms) : 0, 32800
AppSec [candidate] (32.491 ms) : 0, 32491
Debugger [baseline] (65.937 ms) : 0, 65937
Debugger [candidate] (65.738 ms) : 0, 65738
Remote Config [baseline] (578.146 µs) : 0, 578
Remote Config [candidate] (573.658 µs) : 0, 574
Telemetry [baseline] (7.832 ms) : 0, 7832
Telemetry [candidate] (7.82 ms) : 0, 7820
Flare Poller [baseline] (3.513 ms) : 0, 3513
Flare Poller [candidate] (3.508 ms) : 0, 3508
ProfilingAgent [baseline] (93.233 ms) : 0, 93233
ProfilingAgent [candidate] (93.675 ms) : 0, 93675
Profiling [baseline] (93.798 ms) : 0, 93798
Profiling [candidate] (94.235 ms) : 0, 94235
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section baseline
no_agent (1.243 ms) : 1232, 1254
. : milestone, 1243,
iast (3.467 ms) : 3412, 3522
. : milestone, 3467,
iast_FULL (5.876 ms) : 5816, 5937
. : milestone, 5876,
iast_GLOBAL (3.631 ms) : 3564, 3697
. : milestone, 3631,
profiling (2.034 ms) : 2016, 2052
. : milestone, 2034,
tracing (1.895 ms) : 1879, 1911
. : milestone, 1895,
section candidate
no_agent (1.262 ms) : 1249, 1274
. : milestone, 1262,
iast (3.297 ms) : 3250, 3343
. : milestone, 3297,
iast_FULL (5.918 ms) : 5860, 5977
. : milestone, 5918,
iast_GLOBAL (3.535 ms) : 3483, 3587
. : milestone, 3535,
profiling (2.411 ms) : 2386, 2436
. : milestone, 2411,
tracing (1.936 ms) : 1919, 1953
. : milestone, 1936,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section baseline
no_agent (18.133 ms) : 17949, 18317
. : milestone, 18133,
appsec (18.661 ms) : 18475, 18846
. : milestone, 18661,
code_origins (18.012 ms) : 17837, 18188
. : milestone, 18012,
iast (17.759 ms) : 17581, 17937
. : milestone, 17759,
profiling (18.63 ms) : 18447, 18813
. : milestone, 18630,
tracing (17.93 ms) : 17754, 18107
. : milestone, 17930,
section candidate
no_agent (18.126 ms) : 17943, 18309
. : milestone, 18126,
appsec (18.74 ms) : 18552, 18929
. : milestone, 18740,
code_origins (17.759 ms) : 17585, 17933
. : milestone, 17759,
iast (17.845 ms) : 17668, 18022
. : milestone, 17845,
profiling (18.448 ms) : 18267, 18628
. : milestone, 18448,
tracing (17.992 ms) : 17814, 18171
. : milestone, 17992,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section baseline
no_agent (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.38 s) : 18380000, 18380000
. : milestone, 18380000,
iast_GLOBAL (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
profiling (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (14.622 s) : 14622000, 14622000
. : milestone, 14622000,
iast (18.528 s) : 18528000, 18528000
. : milestone, 18528000,
iast_GLOBAL (18.152 s) : 18152000, 18152000
. : milestone, 18152000,
profiling (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
tracing (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~4104dc661a, baseline=1.62.0-SNAPSHOT~9aedff24d2
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.823 ms) : 3601, 4046
. : milestone, 3823,
iast (2.275 ms) : 2205, 2345
. : milestone, 2275,
iast_GLOBAL (2.315 ms) : 2245, 2385
. : milestone, 2315,
profiling (2.099 ms) : 2044, 2155
. : milestone, 2099,
tracing (2.078 ms) : 2024, 2132
. : milestone, 2078,
section candidate
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (2.541 ms) : 2486, 2596
. : milestone, 2541,
iast (2.278 ms) : 2208, 2348
. : milestone, 2278,
iast_GLOBAL (2.307 ms) : 2237, 2378
. : milestone, 2307,
profiling (2.096 ms) : 2041, 2151
. : milestone, 2096,
tracing (2.094 ms) : 2040, 2148
. : milestone, 2094,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorCode.GENERALwhenflag.allocationswas an empty list.forloop at line 111 simply does not iterate, and execution falls through to the existingreturn DEFAULTat line 155.reason=DEFAULTand no error code.Behaviour change
flag.allocationsis emptyreason=ERROR,errorCode=GENERALreason=DEFAULT, no error codeflag.allocationsis nullreason=ERROR,errorCode=GENERAL(explicit guard)reason=ERROR,errorCode=GENERAL(NPE caught by existing catch block)Test plan
evaluate()with an empty allocations list assertreason=DEFAULTand no error code.