London | 26-ITP-May | Remi M. | Sprint 2 | Wireframe#1306
London | 26-ITP-May | Remi M. | Sprint 2 | Wireframe#1306remimarcelle wants to merge 10 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. Can you address the following issues to fully meet all the requirements?
-
For each article, include an actual summary and assign a URL of a relevant resource to the link.
-
Improve the Lighthouse Accessibility score from 92 to 100.
- Address the warning given by https://validator.w3.org/.
…boarding into feature/wireframe
|
done |
|
Changes look good. Well done! |
If it were me, I would consult AI, asking it interactively until I get the layout I expect and until I understand every piece of code AI shows me. CSS Grid Layout is a very powerful way to layout elements. You may wan to explore and experiment with this layout mechanism.
If you are certain you do no need anything in a repo for good, you can delete the repo. |

Learners, PR Template
Self checklist
Changelist
This pull request attempts to complete the requirements for the Wireframe task. The page is built using using semantic HTML tags and includes a header, main section, and footer. Inside the main section are three articles, each featuring a clear heading, a casual and informative summary, and a functional external link.
The footer has been updated with contextual information about the project, including a link to the relevant GitHub issue.
Lighthouse scores at the time of submission were 92 for accessibility
Related issue: remimarcelle/My-Coursework-Planner#7
Questions
There was something I really struggled with and that is making the images fit into the article boxes, and also putting a divider line between the image and article title. I tried so many different ways. So, if you have advice about that that would be great. Also, what do I do with all of these forks? Do I just delete them? Because it's making my Github messy.