Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Form Controls#1283
Open
asandagwala wants to merge 1 commit into
Open
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Form Controls#1283asandagwala wants to merge 1 commit into
asandagwala wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
asandagwala
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
asandagwala
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
asandagwala
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
asandagwala
changed the title
asandagwala
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
May 19, 2026
| <input> | ||
| <label>Colour</label> | ||
| <input> | ||
| <label>Size</label> |
Contributor
There was a problem hiding this comment.
I can't currently select a size - can you add that functionality so the requirements as below are met
What size does the customer want? I must provide the following 6 options: XS, S, M, L, XL, XXL
Poonam-raj
reviewed
May 19, 2026
Comment on lines
+20
to
+21
| <label>Colour</label> | ||
| <input> |
Contributor
There was a problem hiding this comment.
I can't currently select a colour - please add the ability to select a comment, as outlined in the README
Poonam-raj
reviewed
May 19, 2026
Comment on lines
+16
to
+19
| <label>Name</label> | ||
| <input> | ||
| <label>Email</label> | ||
| <input> |
Contributor
There was a problem hiding this comment.
At the moment, I can keep these inputs blank but the actual requirements say there are some rules here - can you find these rules and make these two inputs stricter?
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
May 19, 2026
Comment on lines
23
to
26
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> |
Contributor
There was a problem hiding this comment.
Please remove unnecessary comments when you make a pull request
Poonam-raj
reviewed
May 19, 2026
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> |
Contributor
There was a problem hiding this comment.
please change this to your name
Poonam-raj
reviewed
May 19, 2026
Contributor
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Good start - missing some fundamental requirements, which the README.md for this task outlines. Please go through my comments, read through the instructions again and make sure you're fulfilling the acceptance criteria
Poonam-raj
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Form Controls
PR Description