Adds a page about accessibility to the designing bitcoin products section#821
Merged
Adds a page about accessibility to the designing bitcoin products section#821
Conversation
This is currently still a work in progress.
GBKS
added
Copy
Collaborator
|
Add as assignee |
Just to show how to make commits.
Small edit to test.
1) Updated explanations of disability types and included links to statistics. 2) Added in a link on how to test your apps accessibility.
Tried to edit for clarity. Added and updated some links.
1) Updated correct link to quadriplegic using phone 2) Changed heading to "Categories of accessibility needs" 3) Added paragraph about Illiteracy 4$ Added statistic source link to Hearing paragraph
…itcoinDesign/Guide into feature/new-accessibility-page
sbddesign
requested changes
May 22, 2022
Collaborator
sbddesign
left a comment
sbddesign
left a comment
There was a problem hiding this comment.
Great work! Left a lot of grammar and style edits. Also suggesting we add a modal option to the example image carousels.
Collaborator
|
Just realized this was in draft mode. Sorry for providing such hyper-detailed feedback early when you may not have been ready for it. |
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Co-authored-by: Stephen DeLorme <stephen@stephendelorme.com>
Collaborator
Really appreciate your thorough feedback @sbddesign, very much appreciated. I've applied all those suggestions you've made. |
Contributor
Author
|
@sbddesign I think all your feedback is addressed and the page is ready for another review. |
Bosch-0
approved these changes
Jun 3, 2022
Collaborator
Bosch-0
left a comment
Bosch-0
left a comment
There was a problem hiding this comment.
All LGTM, great work on this page guys. I learnt a lot reading it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds general information about the importance of accessibility, practical tips to get started, and some useful resources.
🙉Check the preview🥸
Closes #754.